feat(api): enable dynamic JFR stop, delete #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2023
andrewazores
force-pushed
the
http-recording-stop-delete
branch
from
c08f6e9
to
6d4c266
Compare
andrewazores
force-pushed
the
124-epic-two-way-communications-protocol
branch
from
0a60a1f
to
7b774d9
Compare
andrewazores
force-pushed
the
http-recording-stop-delete
branch
from
6d4c266
to
2d4ce74
Compare
4 tasks
andrewazores
force-pushed
the
http-recording-stop-delete
branch
from
2d4ce74
to
e4df526
Compare
mwangggg
reviewed
Aug 11, 2023
mwangggg
reviewed
Aug 14, 2023
mwangggg
approved these changes
Aug 14, 2023
andrewazores
merged commit 6154aa8
into
cryostatio:124-epic-two-way-communications-protocol
6 checks passed
andrewazores
added a commit
that referenced
this pull request
Aug 14, 2023
* end paths with / so as to not match by prefix * refactor: extract methods * add utility for extracting ID from path * add handling for stopping recording * add handling for closing (deleting) recording * only allow GET requests if write-operations are not enabled * extract HTTP response body length constants
mwangggg
pushed a commit
to mwangggg/cryostat-agent
that referenced
this pull request
Aug 16, 2023
* end paths with / so as to not match by prefix * refactor: extract methods * add utility for extracting ID from path * add handling for stopping recording * add handling for closing (deleting) recording * only allow GET requests if write-operations are not enabled * extract HTTP response body length constants
mwangggg
pushed a commit
to mwangggg/cryostat-agent
that referenced
this pull request
Aug 24, 2023
* end paths with / so as to not match by prefix * refactor: extract methods * add utility for extracting ID from path * add handling for stopping recording * add handling for closing (deleting) recording * only allow GET requests if write-operations are not enabled * extract HTTP response body length constants
mwangggg
pushed a commit
to mwangggg/cryostat-agent
that referenced
this pull request
Aug 31, 2023
* end paths with / so as to not match by prefix * refactor: extract methods * add utility for extracting ID from path * add handling for stopping recording * add handling for closing (deleting) recording * only allow GET requests if write-operations are not enabled * extract HTTP response body length constants
andrewazores
added a commit
that referenced
this pull request
Sep 19, 2023
* end paths with / so as to not match by prefix * only allow GET requests if write-operations are not enabled * feat(api): implement GET /recordings/:id for streaming files * feat(api): enable dynamic JFR start (#165) * feat(api): enable dynamic JFR stop, delete (#176) Co-authored-by: Ming Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #165
Related to #124
Adds remote endpoint ability to HTTP request Agent to stop or delete JFR by ID.