Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(harvester): ensure empty snapshots are closed #392

Merged
merged 4 commits into from
May 6, 2024
Merged

fix(harvester): ensure empty snapshots are closed #392

merged 4 commits into from
May 6, 2024

Conversation

andrewazores
Copy link
Member

Fixes #391

mwangggg
mwangggg approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrewazores andrewazores merged commit 4fbdb0b into cryostatio:main May 6, 2024
9 checks passed
@andrewazores andrewazores deleted the gh391 branch May 6, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwangggg mwangggg mwangggg approved these changes

Assignees
No one assigned
Labels
fix safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Harvester-created snapshots are left behind if they are empty when created
2 participants
@andrewazores @mwangggg