Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(harvester): ensure empty snapshots are closed #392

Merged
merged 4 commits into from
May 6, 2024
Merged

fix(harvester): ensure empty snapshots are closed #392

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d72393a
fix(harvester): ensure empty snapshots are closed
andrewazores Apr 29, 2024
26db8af
check size after dumping to file in case in-memory buffer has not bee…
andrewazores Apr 29, 2024
2c40396
harvester recordings should write to disk repository by default
andrewazores Apr 29, 2024
c86e810
Revert "harvester recordings should write to disk repository by default"
andrewazores Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/io/cryostat/agent/harvest/Harvester.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,14 +347,14 @@ private Future<Void> uploadOngoing() {

private Future<Void> uploadOngoing(PushType pushType, RecordingSettings settings) {
Recording recording = settings.apply(flightRecorder.takeSnapshot());
if (recording.getSize() < 1) {
return CompletableFuture.failedFuture(
new IllegalStateException("No source recording data"));
}
try {
Path exitPath = Files.createTempFile(null, null);
Files.write(exitPath, new byte[0], StandardOpenOption.TRUNCATE_EXISTING);
recording.dump(exitPath);
if (Files.size(exitPath) < 1) {
return CompletableFuture.failedFuture(
new IllegalStateException("No source recording data"));
}
log.trace("Dumping {}({}) to {}", recording.getName(), recording.getId(), exitPath);
return client.upload(pushType, sownRecording, maxFiles, exitPath)
.thenRun(
Expand Down
Loading