feat(replace-param): Fine-grained replacement parameter for Start Recording Mutator #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aali309
changed the title
aali309
changed the title
tthvo
reviewed
Jul 12, 2023
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
aali309
force-pushed
the
replace_param_startRecording_mutator
branch
from
5c6fc2e
to
a89f71e
Compare
|
Test image available: |
|
Test image available: |
tthvo
reviewed
Jul 17, 2023
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
tthvo
reviewed
Jul 17, 2023
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
tthvo
reviewed
Jul 17, 2023
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
maxcao13
reviewed
Jul 18, 2023
src/main/java/io/cryostat/net/web/http/api/v2/graph/StartRecordingOnTargetMutator.java
Outdated
Show resolved
Hide resolved
aali309
force-pushed
the
replace_param_startRecording_mutator
branch
from
a1c614c
to
380d15d
Compare
|
Test image available: |
|
Test image available: |
maxcao13
reviewed
Jul 19, 2023
src/main/java/io/cryostat/net/web/http/api/v2/graph/StartRecordingOnTargetMutator.java
Outdated
Show resolved
Hide resolved
|
Test image available: |
|
Test image available: |
maxcao13
reviewed
Jul 20, 2023
src/main/java/io/cryostat/recordings/RecordingTargetHelper.java
Outdated
Show resolved
Hide resolved
maxcao13
reviewed
Jul 20, 2023
src/main/java/io/cryostat/net/web/http/api/v2/graph/StartRecordingOnTargetMutator.java
Outdated
Show resolved
Hide resolved
aali309
force-pushed
the
replace_param_startRecording_mutator
branch
from
50c2c74
to
7cb9a7e
Compare
|
Test image available: |
|
Test image available: |
aali309
force-pushed
the
replace_param_startRecording_mutator
branch
from
3f6ccf5
to
e0bc84a
Compare
andrewazores
approved these changes
Aug 16, 2023
|
Test image available: |
|
Test image available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1492
Description of the change:
*This change changes the previous behavior: query parameter ?restart=[true|false] but is now deprecated, and a new replacement ?replace=[always,stopped,never] introduced. ?replace=always would behave the same as ?restart=true, ?replace=never would behave the same as ?restart=false, and ?replace=stopped would implement the quoted behavior. If replace is not specified then it should behave like ?replace=never, so that this also maintains consistency and compatibility with the existing ?restart=false default behavior.
Motivation for the change:
This change is helpful because it enhances the behavior of restart recording while keeping the same request format
How to manually test: