Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployment): adjust resource requests #617

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 29, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Related to https://github.com/cryostatio/cryostat/issues/1629

Description of the change:

Tweaks default resource requests for operand containers.

Motivation for the change:

This aligns the resource requests with the rough minimums applied in the Cryostat smoketest. It is no hard rule or exact science, but these numbers should generally result in a working Cryostat deployment that is able to reliably handle modestly sized JFR files with reasonable speed.

@andrewazores andrewazores added the feat New feature or request label Aug 29, 2023
@mergify mergify bot added the safe-to-test label Aug 29, 2023
@andrewazores andrewazores force-pushed the resource-requests branch 2 times, most recently from 5ac4aa9 to ce2de40 Compare September 12, 2023 13:43
@andrewazores andrewazores changed the title feat(deployment): if no reports sidecar, assign those resources to core container instead feat(deployment): adjust resource requests Sep 12, 2023
@andrewazores andrewazores marked this pull request as ready for review September 12, 2023 14:37
@andrewazores andrewazores changed the title feat(deployment): adjust resource requests chore(deployment): adjust resource requests Sep 12, 2023
@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. and removed feat New feature or request labels Sep 12, 2023
ebaron
ebaron previously approved these changes Sep 15, 2023
@tthvo
Copy link
Member

tthvo commented Sep 15, 2023

Sorry, we might also need to update the doc?

By default, the operator deploys Cryostat with pre-configured resource requests:

@andrewazores andrewazores merged commit 893189e into cryostatio:main Sep 15, 2023
14 checks passed
@andrewazores andrewazores deleted the resource-requests branch September 15, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants