Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): remove auth negotiation and JMX credentials passthrough #1181

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#208

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewazores
Copy link
Member Author

andrewazores commented Dec 15, 2023

I should have mentioned - this is also mutually dependent on cryostatio/cryostat#209 since I changed the WebSocket notifications URL. The rest of the changes should work on their own, however, that would be hard to test since the web client will refuse to do anything until it has a WebSocket connection.

@andrewazores andrewazores merged commit c4b70f5 into cryostatio:main Dec 21, 2023
18 checks passed
@andrewazores andrewazores deleted the auth-rewrite branch December 21, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants