Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(archives): adjust queries and response handling for updated data schema #1221

Merged

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Mar 1, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Based on #1219
Depends on cryostatio/cryostat#312

With this change, the following views should work as expected again:

  1. Recordings > Archived
  2. Archives > All Targets
  3. Archives > All Archives (already working before this PR)
  4. Archives > Uploads, but this also requires fix(archives): accept and delete recording uploads, emit event with correct size cryostat#314

@andrewazores andrewazores marked this pull request as ready for review March 4, 2024 19:17
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 885487b into cryostatio:cryostat3-graphql Mar 4, 2024
11 checks passed
@andrewazores andrewazores deleted the cryostat3-archives branch March 4, 2024 21:09
andrewazores added a commit that referenced this pull request Mar 20, 2024
…schema (#1221)

* fix(archives): adjust queries and response handling for updated data schema
andrewazores added a commit that referenced this pull request Apr 13, 2024
…schema (#1221)

* fix(archives): adjust queries and response handling for updated data schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants