Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pf5): upgrade Security view to Patternfly 5 #1333

Merged
merged 17 commits into from
Sep 3, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Aug 23, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1303
Depends on #1334

Description of the change:

Upgraded Security View to Patternfly 5.

Minor changes

Changes Description Screenshot
Use File Icon to represent a Certificate entry More descriptive of what the text represents. Ideally, this cert icon should be used, but required Pro subscription :( image

Major changes

Changes Description Screenshot
New search bar for finding a credential by match expression & Count is displayed a "container" icon to toggle expanded views (similar to Archive view) Easier to find a credential image

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Aug 23, 2024
@tthvo tthvo marked this pull request as ready for review August 29, 2024 20:07
@tthvo tthvo requested a review from a team August 29, 2024 20:07
@tthvo
Copy link
Member Author

tthvo commented Aug 29, 2024

I think this should be ready for review now. Just likely need to resolve some conflicts with the new MatchExpressionDisplay component after #1334 :D

Copy link

github-actions bot commented Sep 3, 2024

This PR/issue depends on:

@andrewazores andrewazores merged commit ad5a975 into cryostatio:pf5 Sep 3, 2024
14 of 18 checks passed
@tthvo tthvo deleted the pf5-security branch September 3, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants