-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pf5): revamp general table styles and upgrade archive/events views to PF5 #1334
Conversation
Signed-off-by: Thuan Vo <[email protected]>
Ahh,
Oh yes, I have been investigating this for some time. I think it has something to do with Might be related: patternfly/react-topology#10 |
Also, all reviews above for localization are addressed ^^ |
I noticed that sometimes when this happens, reloading will render the view with errors and requests for discovery tree/target lists are returning status code 500. Logs should some error with JDBC connection. {"details":"Error id 59d3b77c-e39f-41a6-b01f-5581497fba5f-343","stack":""} Log: https://gist.github.com/tthvo/05e808ad824bbf728ab4af097e20b7dd |
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1303
Description of the change:
Rules
,Recordings
,Events
,Archives
.Archive
view to Patternfly 5 (Dark theme should also be compatible here).Event
view to Patternfly 5 (Dark theme should also compatible here).Notes: Security view can use some of these changes here. Maybe those can be applied in #1333
Minor changes
<SearchInput />
instead of<TextInput />
componentMajor changes