Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
mmsqe committed Oct 31, 2024
1 parent a4794ad commit f00d261
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion server/json_rpc.go
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ func StartJSONRPC(
// The calling process canceled or closed the provided context, so we must
// gracefully stop the JSON-RPC server.
logger.Info("stopping JSON-RPC server...", "address", config.JSONRPC.Address)
if err := httpSrv.Shutdown(context.Background()); err != nil {
err = httpSrv.Shutdown(context.Background())
if err != nil {

Check warning on line 152 in server/json_rpc.go

View check run for this annotation

Codecov / codecov/patch

server/json_rpc.go#L151-L152

Added lines #L151 - L152 were not covered by tests
logger.Error("failed to shutdown JSON-RPC server", "error", err.Error())
}
return err

Check warning on line 155 in server/json_rpc.go

View check run for this annotation

Codecov / codecov/patch

server/json_rpc.go#L155

Added line #L155 was not covered by tests
Expand Down

0 comments on commit f00d261

Please sign in to comment.