Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed listener closing in gracefully shutdown json-rpc server #550

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

valli0x
Copy link

@valli0x valli0x commented Oct 31, 2024

we don't need to close listener when call server.Shutdown, otherwise we will get an error

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.17%. Comparing base (8afdc69) to head (1ab6df3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
server/json_rpc.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #550   +/-   ##
========================================
  Coverage    46.17%   46.17%           
========================================
  Files          181      181           
  Lines        18124    18124           
========================================
  Hits          8368     8368           
  Misses        9039     9039           
  Partials       717      717           
Files with missing lines Coverage Δ
server/json_rpc.go 0.00% <0.00%> (ø)

server/json_rpc.go Outdated Show resolved Hide resolved
@valli0x valli0x force-pushed the graceful-shutdown-jsonrpc branch from f00d261 to de52912 Compare October 31, 2024 15:49
@yihuang yihuang merged commit e52a555 into crypto-org-chain:develop Nov 1, 2024
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants