-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chapter/compute: Restructure repo according to updated methodology #74
Conversation
23bd8ec
to
cffeefe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made an initial, high-level pass. Fix my inline suggestions and the more general ones listed below (especially the one regarding building the site) and then I'll give this another look.
- Add the following line at the end of each task:
"If you're having difficulties solving this exercise, go through [this](link to the relevant section in reading/) reading material."
use git rm -rf content/chapters/compute
to remove all remaining files in that folder once they're moved- Squash your commits into a single one because
checkpatch
runs on all commits every time. Further amend this single commit andgit push -f
upon every new review without adding additional commits.
chapters/compute/processes-threads-apache2/drills/tasks/apache2/support/Dockerfile
Outdated
Show resolved
Hide resolved
chapters/compute/processes-threads-apache2/guides/apache2/support/Dockerfile
Outdated
Show resolved
Hide resolved
chapters/compute/processes/drills/tasks/create-process/solution/fork.c
Outdated
Show resolved
Hide resolved
chapters/compute/processes/drills/tasks/create-process/support/fork.c
Outdated
Show resolved
Hide resolved
eb27e7b
to
691e5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave you the fixes to config.yaml
so the website builds properly. Apply them, then take care of my other suggestions.
- Change this line [1] to
- 'chapters/compute/**/*'
so the PR label fortopic/compute
is assigned correctly. - Remove the
arena/
folder. Extract all tasks from it and place them in whatever subchapter they fit best underdrills/tasks/
. You can prefix their names with "BONUS - " inconfig.yaml
if they're more difficult. - Add the following line at the end of each task:
"If you're having difficulties solving this exercise, go through [this](link to the relevant section in reading/) reading material."
[1]
operating-systems/.github/labeler.yml
Line 8 in eb0056b
- 'content/chapters/compute/**/*' |
691e5d0
to
774bc46
Compare
@teodutu, @razvand, @VladNastase I finished the directory structure change but the builder seems to fail (check action for logs). From what I understand, it complains that some media files are invalid. This is very weird since
The media paths are defined with |
774bc46
to
13ed0ff
Compare
It seems there were other issues I missed:
This error makes no sense, I ran The real problem seems to be:
It was either this or solving the dangling references in the .md files. |
0879431
to
6e25060
Compare
Published at https://cs-pub-ro.github.io/operating-systems/74/ |
6cbd256
to
e6fbe38
Compare
Published at https://cs-pub-ro.github.io/operating-systems/74/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only found one rendering issue. Fix that and then I'm OK with this. And fix the merge conflict by moving the tasks to the beginning of each lab.
chapters/compute/synchronization/drills/tasks/race-condition/README.md
Outdated
Show resolved
Hide resolved
Copy jpeg media files to .view/media as they are used in Compute chapter. Signed-off-by: Alex Apostolescu <[email protected]>
Relative links were checked only for questions, reading, and media files. Handle tasks and guides in a similar way. Signed-off-by: Alex Apostolescu <[email protected]>
e6fbe38
to
cf2e761
Compare
cf2e761
to
bf0147a
Compare
Published at https://cs-pub-ro.github.io/operating-systems/74/ |
1. Print the address and value of `var` in each thread. | ||
See that they differ. | ||
|
||
1. Modify the value of `var` in the `main()` function before calling `pthread_create()`. | ||
Notice that the value doesn't propagate to the other threads. | ||
This is because, upon creating a new thread, its TLS is initialised. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Print the address and value of `var` in each thread. | |
See that they differ. | |
1. Modify the value of `var` in the `main()` function before calling `pthread_create()`. | |
Notice that the value doesn't propagate to the other threads. | |
This is because, upon creating a new thread, its TLS is initialised. | |
2. Print the address and value of `var` in each thread. | |
See that they differ. | |
3. Modify the value of `var` in the `main()` function before calling `pthread_create()`. | |
Notice that the value doesn't propagate to the other threads. | |
This is because, upon creating a new thread, its TLS is initialised. |
Now because you removed the indent above, these list items aren't numbered properly because there's a break in the list. Just number them manually, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think I just have to indent the subsequent phrases.
1. Print the address and value of `var` in each thread.
See that they differ.
should be written as:
1. Print the address and value of `var` in each thread.
See that they differ.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this, I misread your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so the problem was that quizzes had the wrong indent. Seems like markdown expects 3 spaces
indentation when you are under a numbered list.
- Break arena into smaller sections and put it under sections - Make tasks self-contained - Generate support from solution whenever possible Signed-off-by: Andrei Miga <[email protected]> Signed-off-by: Alex Apostolescu <[email protected]>
bf0147a
to
8bdc6b3
Compare
Published at https://cs-pub-ro.github.io/operating-systems/74/ |
Prerequisite Checklist
Description of changes
Restructure Compute chapter to match the OpenEdu methodology