Address pkgdown job failures #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2a8c1f2.
Don't eval last code chunk. Add example output in place of previously evaled output. Fix typos.
Enlarge image.
…e, and initializes log connection' Explicit set TZ from env to align with set_script_run_time() behavior.
Replace sqlite test DBs with duckdb to guarantee test DBs are in-memory and non-persistent.
Added ', shutdown=TRUE' to the dbDisconnects on duckdb connections.
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the pkgdown build errors encountered in releases 1.17.0 and 1.17.1. 1.17.2 was a train wreck and I crashed that train. The
job_logging.Rmdincluded in 1.17.2 wouldn't even knit locally.I regretted not testing these vignette iterations with
pkgdown::build_site(), but I have since tested that command against 1.17.0, 1.17.1, 1.17.2, and the code on this PR. All built correctly except 1.17.2. In short, it's hard to anticipate when the Github Infrastructure will fail when building a pkgdown site.So in reviewing this PR, I think I'm asking you, @ChemiKyle, to tell me if you think the cessation of code evaluation and the use of a static image is a reasonable approach to circumventing the build failures.