Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address pkgdown job failures #143

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Address pkgdown job failures #143

merged 9 commits into from
Nov 21, 2023

Commits on Nov 19, 2023

  1. Revert "Update vignettes/job_logging.Rmd to fix build errors" 

    This reverts commit 2a8c1f2.
    @pbchase
    pbchase committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b1a7d32 View commit details
    Browse the repository at this point in the history

  2. Update vignettes/job_logging.Rmd to fix build errors 

    Don't eval last code chunk.
Add example output in place of previously evaled output.
Fix typos.
    @pbchase
    pbchase committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    baafbe1 View commit details
    Browse the repository at this point in the history

  3. Update job_logging.Rmd 

    Enlarge image.
    @pbchase
    pbchase committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    1ede155 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Address pkgdown::build_site() complaints about non-parsable code exam… 

    …ples
    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    b17abeb View commit details
    Browse the repository at this point in the history

  2. Address lots of pkgdown::build_site() complaints about garbage-collec… 

    …ted connections
    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a7b6d8f View commit details
    Browse the repository at this point in the history

  3. Fix 11 warnings about dplyr::all_equal() in tests

    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    48daf3d View commit details
    Browse the repository at this point in the history

  4. Fix error in test 'init_etl properly sets script name, script run tim… 

    …e, and initializes log connection'

Explicit set TZ from env to align with set_script_run_time() behavior.
    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    5c47b70 View commit details
    Browse the repository at this point in the history

  5. Fix intermittent test failures caused by environment vars 

    Replace sqlite test DBs with duckdb to guarantee test DBs are in-memory and non-persistent.
    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    e0a4cd1 View commit details
    Browse the repository at this point in the history

  6. Fix duckdb garbage collection messages from tests 

    Added ', shutdown=TRUE' to the dbDisconnects on duckdb connections.
    @pbchase
    pbchase committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    c12524f View commit details
    Browse the repository at this point in the history