feat(dbt): model dbt tests as asset checks only on their attached dbt node

[rexledesma]

Summary & Motivation

There are certain dbt tests that act on multiple models. For example:

• dbt Singular tests: https://docs.getdbt.com/docs/build/tests#singular-tests
• dbt relationship tests: https://docs.getdbt.com/docs/build/tests#singular-tests
• dbt Great expectations table shape tests: https://github.com/calogica/dbt-expectations/tree/0.10.0/#expect_table_column_count_to_equal_other_table

Currently, for these tests, we emit an AssetCheckResult for each of the models that the test acts on.

However, this runs into an error in subsetting. When you run an individual asset that has this relationship test defined, an exception occurs because two AssetCheckResult's when you run this test. This does not match the expected targeted assets.

A sample error:

dagster._core.errors.DagsterInvariantViolationError: Received unexpected AssetCheckResult. It targets asset 'orders' which is not targeted by any of the checks currently being evaluated. Targeted assets: ['customers'].

Some solutions:

1. We prevent relationship tests from being models as Dagster tests right now.
2. We only model relationship tests on the dbt model that defines the relationship test. The other models that are referenced in the test will not receive an asset check.

In this change, we implement (2). Furthermore, we prevent singular tests from being modeled as dbt tests, as they are not currently defined on a node.

In the future, we can also model singular tests that only target a single dbt node reference.

How I Tested These Changes

pytest: update existing tests, add singular test and assert that it is not modeled as an asset check.

[rexledesma]

Current dependencies on/for this PR:

• master
  • PR feat(asset-checks): allow asset check subsetting #16672
    • PR feat(dbt): model dbt tests as asset checks only on their attached dbt node #16727 👈
      • PR feat(dbt): implement subsetting to execute dbt tests #16801
    • PR subsetting fun #16721

This comment was auto-generated by Graphite.

[PedramNavid]

Nicely done