feat(dbt): implement subsetting to execute dbt tests #16801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexledesma
force-pushed
the
rl/model-dbt-tests-on-attached-node
branch
from
3b1082b to
83b5e63
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
75b53f5 to
100586b
Compare
This was referenced Sep 26, 2023
Closed
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
rexledesma
force-pushed
the
rl/model-dbt-tests-on-attached-node
branch
from
83b5e63 to
228070a
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
100586b to
d6e4af0
Compare
rexledesma
force-pushed
the
rl/model-dbt-tests-on-attached-node
branch
from
228070a to
7674850
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
d6e4af0 to
7452d4a
Compare
Base automatically changed from
rl/model-dbt-tests-on-attached-node
to
master
September 27, 2023 02:22
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
7452d4a to
da4d111
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
2 times, most recently
from
1d7128c to
d2ddd84
Compare
rexledesma
commented
Sep 27, 2023
python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
Outdated
Show resolved
Hide resolved
sryza
reviewed
Sep 27, 2023
python_modules/libraries/dagster-dbt/dagster_dbt/asset_utils.py
Outdated
Show resolved
Hide resolved
python_modules/libraries/dagster-dbt/dagster_dbt/core/resources_v2.py
Outdated
Show resolved
Hide resolved
rexledesma
changed the base branch from
master
to
rl/assert-any-all-asset-check-metadata
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
d2ddd84 to
fc31d83
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
2 times, most recently
from
3d29758 to
a0a3113
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-c7wspd4b0-elementl.vercel.app Direct link to changed pages: |
rexledesma
force-pushed
the
rl/assert-any-all-asset-check-metadata
branch
from
885c787 to
625e26d
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
a0a3113 to
be84e88
Compare
rexledesma
force-pushed
the
rl/assert-any-all-asset-check-metadata
branch
from
625e26d to
0e0819d
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
be84e88 to
b82d4e4
Compare
rexledesma
force-pushed
the
rl/assert-any-all-asset-check-metadata
branch
from
0e0819d to
d13e120
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
b82d4e4 to
c6d2ef4
Compare
rexledesma
force-pushed
the
rl/dbt-subsetting
branch
from
c6d2ef4 to
f6af804
Compare
rexledesma
changed the base branch from
rl/assert-any-all-asset-check-metadata
to
master
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f6af804. |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit f6af804. |
johannkm
approved these changes
Oct 3, 2023
yuhan
pushed a commit
that referenced
this pull request
Oct 3, 2023
## Summary & Motivation Add the ability to select individual dbt tests when subsetting the execution of a dbt project. Now that users can explicitly select for both tests and models, we should disable dbt's indirect selection: https://docs.getdbt.com/reference/node-selection/test-selection-examples?indirect-selection-mode=empty#indirect-selection. dbt's indirect selection basically controls whether tests are automatically run when a dbt model is built. Previously, in the case for `dbt build`, all tests associated with a dbt model would be run if the model is materialized. Now, we only run the tests that were explicitly selected and are available in the asset definition's context. ## How I Tested These Changes local, pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add the ability to select individual dbt tests when subsetting the execution of a dbt project.
Now that users can explicitly select for both tests and models, we should disable dbt's indirect selection: https://docs.getdbt.com/reference/node-selection/test-selection-examples?indirect-selection-mode=empty#indirect-selection.
dbt's indirect selection basically controls whether tests are automatically run when a dbt model is built. Previously, in the case for
dbt build, all tests associated with a dbt model would be run if the model is materialized. Now, we only run the tests that were explicitly selected and are available in the asset definition's context.How I Tested These Changes
local, pytest