-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dbt): enforce all-or-nothing opt-in for asset checks #16852
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
885c787
to
625e26d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a global setting, might it make sense as an argument to dbt_assets or somehow on the DagsterDbtTranslator, instead as test-level config?
We could probably consider adding it to |
625e26d
to
0e0819d
Compare
0e0819d
to
d13e120
Compare
With that change, would we also need this change? |
Unless we want to break users who have been enabling asset checks using their dbt project's metadata, we will still need this change. |
I think we should be comfortable breaking them if we think it's the right direction. We expect users who sign up to be design partners for features before their public release to be able to sustain breaking changes to those features. |
## Summary & Motivation As discussed in #16852, enabling asset checks is an all-or-nothing operation. In order to not confuse users about this behavior, we will only allow users to enable this feature through a binary toggle, rather than setting the metadata on individual dbt tests. Here, we use `DagsterDbtTranslator` as the object that contains the settings that a user can configure to enable features on their dbt project when consuming it with Dagster. One thing to note here is that custom subclasses that implement their own `__init__` will need to also pass down the settings object if they are opting into asset checks. ## How I Tested These Changes pytest
Summary & Motivation
As the title.
How I Tested These Changes
pytest