Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MiddleTruncate component on Asset detail page #16961

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Use MiddleTruncate component on Asset detail page #16961

merged 1 commit into from
Oct 2, 2023

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Oct 2, 2023

Summary & Motivation

  • Middle truncate partition names in the partition list
  • Middle truncate partition names in the partition selection dialog

How I Tested These Changes

Screenshot 2023-10-02 at 3 17 58 PM Screenshot 2023-10-02 at 3 16 21 PM Screenshot 2023-10-02 at 3 16 18 PM

@salazarm salazarm requested review from bengotow and hellendag October 2, 2023 19:19
salazarm
salazarm commented Oct 2, 2023
View reviewed changes
js_modules/dagster-ui/packages/ui-components/src/components/TagSelector.tsx
<span>{tag}</span>
<div
style={{
display: 'grid',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to use display grid over adding grow: 1 on the children components because I only have to set styles on the parent div rather than both the parent and the child divs, I also find it more reliable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me! Maybe sometime soon we bake grid into Box

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-i9vyfoocz-elementl.vercel.app
https://salazarm-middle-truncation-partitions.components-storybook.dagster-docs.io

Built with commit 1d746c4.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-h7nq83akd-elementl.vercel.app
https://salazarm-middle-truncation-partitions.core-storybook.dagster-docs.io

Built with commit 1d746c4.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm linked an issue Oct 2, 2023 that may be closed by this pull request
Partition selection doesn't show status for long partition names #16668
Closed
bengotow
bengotow approved these changes Oct 2, 2023
View reviewed changes
js_modules/dagster-ui/packages/ui-components/src/components/TagSelector.tsx
<span>{tag}</span>
<div
style={{
display: 'grid',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me! Maybe sometime soon we bake grid into Box

@salazarm salazarm merged commit f4d1ed8 into master Oct 2, 2023
2 checks passed
@salazarm salazarm deleted the salazarm/middle-truncation-partitions branch October 2, 2023 23:15
@hellendag hellendag mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengotow bengotow bengotow approved these changes

@hellendag hellendag Awaiting requested review from hellendag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partition selection doesn't show status for long partition names
2 participants
@salazarm @bengotow