[ui] Improve global search perf #16965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b338d2e. |
hellendag
force-pushed
the
dish/slow-search
branch
from
fe5c773 to
b338d2e
Compare
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit b338d2e. |
salazarm
reviewed
Oct 12, 2023
| // With a very large number of runs, operating on the Apollo cache is too expensive and | ||
| // can block the main thread. This data has to be up-to-the-second fresh anyway, so just | ||
| // skip the cache entirely. | ||
| fetchPolicy: 'no-cache', |
salazarm
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Improve render and interaction performance on global search for users with very large workspaces.
A key part of the problem here is that writing/reading with the Apollo cache becomes prohibitively slow at scale. Therefore:
cache-firstpolicy on search queries. Currently, we always hit the backend when opening search, which can be expensive both in terms of performing the query and updating the cache. Instead, we can leverage the workspace and asset catalog queries to read data from the Apollo cache, if available.How I Tested These Changes
Viewing the app as a user with tens of thousands of objects, open search after the workspace and asset catalog have loaded. Verify that new queries are not performed, and that the data is available to be searched as soon as the cache has populated the values. Close search, reopen it. Verify that search is available right away, without having to wait for the cache to populate the values.