Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Improve global search perf #16965

Merged
merged 1 commit into from
Oct 12, 2023
Merged

[ui] Improve global search perf #16965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/runs/useRunsForTimeline.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ export const useRunsForTimeline = (range: [number, number], runsFilter: RunsFilt

const queryData = useQuery<RunTimelineQuery, RunTimelineQueryVariables>(RUN_TIMELINE_QUERY, {
notifyOnNetworkStatusChange: true,
// With a very large number of runs, operating on the Apollo cache is too expensive and
// can block the main thread. This data has to be up-to-the-second fresh anyway, so just
// skip the cache entirely.
fetchPolicy: 'no-cache',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

variables: {
inProgressFilter: {
...runsFilter,
Expand Down
22 changes: 18 additions & 4 deletions js_modules/dagster-ui/packages/ui-core/src/search/useGlobalSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,12 @@ const EMPTY_RESPONSE = {queryString: '', results: []};
* A `terminate` function is provided, but it's probably not necessary to use it.
*/
export const useGlobalSearch = () => {
const primarySearch = React.useRef<WorkerSearchResult>();
const secondarySearch = React.useRef<WorkerSearchResult>();
const primarySearch = React.useRef<WorkerSearchResult | null>(null);
const secondarySearch = React.useRef<WorkerSearchResult | null>(null);

const primary = useLazyQuery<SearchPrimaryQuery>(SEARCH_PRIMARY_QUERY, {
// Try to make aggressive use of workspace values from the Apollo cache.
fetchPolicy: 'cache-first',
onCompleted: (data: SearchPrimaryQuery) => {
const results = primaryDataToSearchResults({data});
if (!primarySearch.current) {
Expand All @@ -190,6 +192,8 @@ export const useGlobalSearch = () => {
});

const secondary = useLazyQuery<SearchSecondaryQuery>(SEARCH_SECONDARY_QUERY, {
// As above, try to aggressively use asset information from Apollo cache if possible.
fetchPolicy: 'cache-first',
onCompleted: (data: SearchSecondaryQuery) => {
const results = secondaryDataToSearchResults({data});
if (!secondarySearch.current) {
Expand All @@ -202,9 +206,14 @@ export const useGlobalSearch = () => {
const [performPrimaryLazyQuery, primaryResult] = primary;
const [performSecondaryLazyQuery, secondaryResult] = secondary;

// If we already have WebWorkers set up, initialization is complete and this will be a no-op.
const initialize = React.useCallback(async () => {
performPrimaryLazyQuery();
performSecondaryLazyQuery();
if (!primarySearch.current) {
performPrimaryLazyQuery();
}
if (!secondarySearch.current) {
performSecondaryLazyQuery();
}
}, [performPrimaryLazyQuery, performSecondaryLazyQuery]);

const searchPrimary = React.useCallback(async (queryString: string) => {
Expand All @@ -215,9 +224,14 @@ export const useGlobalSearch = () => {
return secondarySearch.current ? secondarySearch.current.search(queryString) : EMPTY_RESPONSE;
}, []);

// Terminate the workers. Be careful with this: for users with very large workspaces, we should
// avoid constantly re-querying and restarting the threads. It should only be used when we know
// that there is fresh data to repopulate search.
const terminate = React.useCallback(() => {
primarySearch.current?.terminate();
primarySearch.current = null;
secondarySearch.current?.terminate();
secondarySearch.current = null;
}, []);

return {
Expand Down