Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gql] Report runless asset events #17019

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

clairelin135
Copy link
Contributor

@clairelin135 clairelin135 commented Oct 4, 2023

This PR adds graphQL to enable reporting asset materializations in the UI.

It creates a reportRunlessAssetEvents mutation with the following arguments:

  • event type -- currently only accepts observations and materializations, though we can use this to support asset checks in the UI in the future
  • asset key -- our planned UIs currently only support targeting one asset at a time
  • partition keys (optional)
  • description (optional)

In the next PR I plan on enabling displaying the creator of a runless event.

@clairelin135 clairelin135 force-pushed the claire/gql-report-runless-asset-event branch 2 times, most recently from 3200f8b to ed6fa98 Compare October 5, 2023 00:10
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-nvkwc8ahj-elementl.vercel.app
https://claire-gql-report-runless-asset-event.core-storybook.dagster-docs.io

Built with commit 4f36358.
This pull request is being automatically deployed with vercel-action

@clairelin135 clairelin135 force-pushed the claire/gql-report-runless-asset-event branch from ed6fa98 to e571010 Compare October 5, 2023 00:26
@clairelin135 clairelin135 marked this pull request as ready for review October 5, 2023 00:27
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

class Meta:
name = "AssetEventType"

def to_dagster_event_type(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type plz

@clairelin135
Copy link
Contributor Author

clairelin135 commented Oct 5, 2023

Corresponding internal PR: https://github.com/dagster-io/internal/pull/7123 to make tests pass

@clairelin135 clairelin135 force-pushed the claire/gql-report-runless-asset-event branch from e571010 to d29c76a Compare October 5, 2023 22:05
@clairelin135
Copy link
Contributor Author

clairelin135 commented Oct 5, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@clairelin135 clairelin135 force-pushed the claire/gql-report-runless-asset-event branch from d29c76a to 4f36358 Compare October 9, 2023 16:20
@clairelin135 clairelin135 merged commit 2567e2d into master Oct 9, 2023
1 check passed
@clairelin135 clairelin135 deleted the claire/gql-report-runless-asset-event branch October 9, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants