Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] AMP Timeline page - Evaluations table, Runs table + Detail modal rows #17054

Merged
merged 10 commits into from
Oct 9, 2023

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Oct 6, 2023

Summary & Motivation

Hooks up the Evaluations table, Runs table, and Detail modal rows

How I Tested These Changes

locally:

Screenshot 2023-10-05 at 9 56 32 PM Screenshot 2023-10-05 at 9 56 16 PM Screenshot 2023-10-05 at 9 54 29 PM Screenshot 2023-10-05 at 9 54 19 PM Screenshot 2023-10-05 at 9 54 10 PM

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-qjjs3mi16-elementl.vercel.app
https://salazarm-amp-timeline2.core-storybook.dagster-docs.io

Built with commit a348d0e.
This pull request is being automatically deployed with vercel-action

@salazarm salazarm force-pushed the salazarm/amp-timeline branch from 660ad2a to cc70012 Compare October 6, 2023 19:44
@salazarm salazarm force-pushed the salazarm/amp-timeline2 branch 2 times, most recently from 16b856b to 434dd4c Compare October 9, 2023 12:02
Base automatically changed from salazarm/amp-timeline to master October 9, 2023 15:44
@salazarm salazarm force-pushed the salazarm/amp-timeline2 branch from 434dd4c to a348d0e Compare October 9, 2023 15:58
@salazarm salazarm merged commit 8b14987 into master Oct 9, 2023
1 check passed
@salazarm salazarm deleted the salazarm/amp-timeline2 branch October 9, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants