Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Dagster UI copy for external assets; add example to toys #17086

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

schrockn
Copy link
Member

@schrockn schrockn commented Oct 9, 2023

Summary & Motivation

All of our docs refer to External assets and we are not going to support executable external assets for this launch, so change the copy accordingly.

How I Tested These Changes

BK. Load in Dagster UI.

Screenshot 2023-10-09 at 1 30 50 PM

@schrockn
Copy link
Member Author

schrockn commented Oct 9, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@schrockn schrockn changed the title Add toys repo for external assets Change Dagster UI copy for external assets; add example to toys Oct 9, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-moodsnk5r-elementl.vercel.app
https://extenral-assets-toys.core-storybook.dagster-docs.io

Built with commit 3a20d80.
This pull request is being automatically deployed with vercel-action

@schrockn schrockn requested a review from bengotow October 9, 2023 17:31
@schrockn schrockn marked this pull request as ready for review October 9, 2023 17:31
@schrockn schrockn force-pushed the extenral-assets-toys branch from ee554fb to 706b0e5 Compare October 9, 2023 17:46
@schrockn schrockn changed the base branch from external-multi-asset-mitigation to master October 9, 2023 17:46
@schrockn schrockn force-pushed the extenral-assets-toys branch from 706b0e5 to 3a20d80 Compare October 9, 2023 17:46
@schrockn schrockn merged commit 3c0b777 into master Oct 9, 2023
2 checks passed
@schrockn schrockn deleted the extenral-assets-toys branch October 9, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants