Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove top level assetChecksOrError resolver #17647

Merged

Conversation

johannkm
Copy link
Contributor

@johannkm johannkm commented Nov 2, 2023

This is replaced by AssetNode.assetChecksOrError

@johannkm johannkm requested review from sryza and bengotow November 2, 2023 18:55
@johannkm johannkm force-pushed the johann/11-02-remove_top_level_assetChecksOrError_resolver branch from 8e69444 to 869b085 Compare November 2, 2023 19:58
Copy link

github-actions bot commented Nov 2, 2023

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-r04ojgm7o-elementl.vercel.app
https://johann-11-02-remove-top-level-assetChecksOrError-resolver.core-storybook.dagster-docs.io

Built with commit efa6d08.
This pull request is being automatically deployed with vercel-action

@johannkm johannkm requested review from rexledesma and removed request for bengotow November 2, 2023 20:05
Base automatically changed from johann/11-02-Remove_AssetNode.assetChecks_resolver to master November 2, 2023 20:26
@johannkm johannkm force-pushed the johann/11-02-remove_top_level_assetChecksOrError_resolver branch from 869b085 to efa6d08 Compare November 2, 2023 20:53
@johannkm johannkm merged commit ef98a86 into master Nov 2, 2023
2 checks passed
@johannkm johannkm deleted the johann/11-02-remove_top_level_assetChecksOrError_resolver branch November 2, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants