batch fetching asset records for asset checks #17654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 2, 2023
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
johannkm
force-pushed
the
johann/11-02-remove_executions_resolver_on_GrapheneAssetCheck
branch
from
57af54a to
d87dc46
Compare
johannkm
force-pushed
the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
from
4d4d14c to
d4ad6d2
Compare
johannkm
commented
Nov 2, 2023
| @@ -153,16 +154,17 @@ def get_checks_for_asset( | |||
|
|
|||
| def _execution_targets_latest_materialization( | |||
| instance: DagsterInstance, | |||
| check_key: AssetCheckKey, | |||
| asset_record: Optional[AssetRecord], | |||
| execution: AssetCheckExecutionRecord, | |||
| resolved_status: AssetCheckExecutionResolvedStatus, | |||
| ) -> bool: | |||
| # always show in progress checks | |||
| if resolved_status == AssetCheckExecutionResolvedStatus.IN_PROGRESS: | |||
There was a problem hiding this comment.
we could get fancy and not fetch records for in progress checks. Too small an optimization to be worth it I thnk
johannkm
force-pushed
the
johann/11-02-remove_executions_resolver_on_GrapheneAssetCheck
branch
from
d87dc46 to
f521d0a
Compare
johannkm
force-pushed
the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
from
d4ad6d2 to
36d5977
Compare
johannkm
force-pushed
the
johann/11-02-remove_executions_resolver_on_GrapheneAssetCheck
branch
from
f521d0a to
3a984c1
Compare
johannkm
force-pushed
the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
from
36d5977 to
ae518cf
Compare
rexledesma
approved these changes
Nov 2, 2023
johannkm
force-pushed
the
johann/11-02-remove_executions_resolver_on_GrapheneAssetCheck
branch
from
3a984c1 to
cc0dd7f
Compare
johannkm
force-pushed
the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
from
ae518cf to
77b5c92
Compare
Base automatically changed from
johann/11-02-remove_executions_resolver_on_GrapheneAssetCheck
to
master
November 2, 2023 22:33
johannkm
force-pushed
the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
from
77b5c92 to
dcb8304
Compare
johannkm
deleted the
johann/11-02-batch_fetching_asset_records_for_asset_checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per title