Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch fetching asset records for asset checks #17654

Merged
merged 1 commit into from
Nov 2, 2023
+17 −6
Merged

batch fetching asset records for asset checks #17654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions python_modules/dagster-graphql/dagster_graphql/implementation/asset_checks_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
AssetCheckExecutionResolvedStatus,
AssetCheckInstanceSupport,
)
from dagster._core.storage.event_log.base import AssetRecord
from dagster._core.workspace.context import WorkspaceRequestContext
from packaging import version

Expand Down Expand Up @@ -153,16 +154,17 @@ def get_checks_for_asset(

def _execution_targets_latest_materialization(
instance: DagsterInstance,
check_key: AssetCheckKey,
asset_record: Optional[AssetRecord],
execution: AssetCheckExecutionRecord,
resolved_status: AssetCheckExecutionResolvedStatus,
) -> bool:
# always show in progress checks
if resolved_status == AssetCheckExecutionResolvedStatus.IN_PROGRESS:
Copy link
Contributor Author

@johannkm johannkm Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could get fancy and not fetch records for in progress checks. Too small an optimization to be worth it I thnk

return True

records = instance.get_asset_records([check_key.asset_key])
latest_materialization = records[0].asset_entry.last_materialization_record if records else None
latest_materialization = (
asset_record.asset_entry.last_materialization_record if asset_record else None
)

if not latest_materialization:
# asset hasn't been materialized yet, so no reason to hide the check
Expand Down Expand Up @@ -224,23 +226,32 @@ def __init__(self, instance: DagsterInstance, check_keys: List[AssetCheckKey]):
def _fetch_executions(self) -> Mapping[AssetCheckKey, Optional[GrapheneAssetCheckExecution]]:
from .fetch_asset_checks import get_asset_check_execution_status

latest_executions = (
latest_executions_by_check_key = (
self._instance.event_log_storage.get_latest_asset_check_execution_by_key(
self._check_keys
)
)
asset_records_by_asset_key = {
record.asset_entry.asset_key: record
for record in self._instance.get_asset_records(
list({ck.asset_key for ck in self._check_keys})
)
}

self._executions = {}
for check_key in self._check_keys:
execution = latest_executions.get(check_key)
execution = latest_executions_by_check_key.get(check_key)
if not execution:
self._executions[check_key] = None
else:
resolved_status = get_asset_check_execution_status(self._instance, execution)
self._executions[check_key] = (
GrapheneAssetCheckExecution(execution, resolved_status)
if _execution_targets_latest_materialization(
self._instance, check_key, execution, resolved_status
instance=self._instance,
asset_record=asset_records_by_asset_key.get(check_key.asset_key),
execution=execution,
resolved_status=resolved_status,
)
else None
)
Expand Down