-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4/n subset refactor] Add whitelist_for_serdes to DefaultPartitionsSubset #17703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
clairelin135
changed the title
first stab
[4/n subset refactor] Add whitelist_for_serdes to DefaultPartitionsSubset
Nov 3, 2023
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 4, 2023 00:01
263cd3b
to
c5fa082
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 4, 2023 00:06
c4e4110
to
1b749a4
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
3 times, most recently
from
November 6, 2023 17:21
1f9247e
to
6ea89d3
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
2 times, most recently
from
November 6, 2023 17:46
227fe1d
to
9e1b34d
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 6, 2023 17:47
6ea89d3
to
d708943
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 6, 2023 17:50
9e1b34d
to
8853217
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 6, 2023 17:55
d708943
to
c0f2d6a
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 6, 2023 17:55
8853217
to
3f158f7
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
2 times, most recently
from
November 6, 2023 21:05
dbaca7d
to
a138c9f
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 6, 2023 21:08
3f158f7
to
aacda59
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
4 times, most recently
from
November 8, 2023 00:15
8ccd9d2
to
ebb715c
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
4 times, most recently
from
November 8, 2023 20:06
028cd58
to
239ef13
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 10, 2023 21:18
8f3652f
to
76e112f
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 10, 2023 22:39
662acf8
to
8afcf46
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
2 times, most recently
from
November 13, 2023 21:04
7e1cb7a
to
f72f939
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 13, 2023 21:12
8afcf46
to
71ba29e
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 14, 2023 17:53
f72f939
to
927eb63
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 14, 2023 17:54
71ba29e
to
15244b0
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 14, 2023 19:55
bda8447
to
fb23a93
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 14, 2023 19:55
15244b0
to
f29befd
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
2 times, most recently
from
November 15, 2023 23:51
1aadacf
to
f88b440
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
2 times, most recently
from
November 16, 2023 00:33
6ea0de0
to
78a91dd
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 16, 2023 20:49
f88b440
to
cd6e384
Compare
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 16, 2023 20:49
78a91dd
to
e6c5ca9
Compare
clairelin135
force-pushed
the
claire/serialize-time-window-partitions-subset
branch
from
November 16, 2023 21:42
cd6e384
to
0e3a4fe
Compare
Base automatically changed from
claire/serialize-time-window-partitions-subset
to
master
November 16, 2023 22:30
continue time window partitions subset changes asset backfill serialization partition mapping update continue refactor fix more tests more test fixes fix partition mapping tests adjust test fix more tests add tests
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 16, 2023 22:36
e6c5ca9
to
66d7ba9
Compare
sryza
approved these changes
Nov 16, 2023
clairelin135
force-pushed
the
claire/default-subset-serialization
branch
from
November 16, 2023 23:08
66d7ba9
to
3195b7e
Compare
gibsondan
added a commit
that referenced
this pull request
Dec 2, 2023
## Summary & Motivation #17703 removed partitions_def from DefaultPartitionMapping, which these optimizations were relying on existing. We should probably remove that field from the base class now that it is no longer reliably there and is only available on time based partition mapping - but that is out of scope for this fix ## How I Tested These Changes Dry run for an asset graph involving multi-partitions finishes quickly again
gibsondan
added a commit
that referenced
this pull request
Dec 2, 2023
## Summary & Motivation #17703 removed partitions_def from DefaultPartitionMapping, which these optimizations were relying on existing. We should probably remove that field from the base class now that it is no longer reliably there and is only available on time based partition mapping - but that is out of scope for this fix ## How I Tested These Changes Dry run for an asset graph involving multi-partitions finishes quickly again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
DefaultPartitionsSubset
serializable by making it aNamedTuple
and removingpartitions_def
from it (as these partitions defs cannot be serialized).This causes a cascading set of changes:
PartitionsSubset
methods such asget_partition_keys_in_range
,get_partition_keys_not_in_subset
must now accept apartitions_def
argPartitionMapping
methods now must accept a partitions def corresponding to a partitions subset, otherwise the partitions def is inaccessibleMultiPartitionsSubset
and modifies callsites to transform partition keys toMultiPartitionKey
s if needed