Only show changed and missing option in node lineage and global asset graph #18198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit af68276. |
bengotow
approved these changes
Nov 22, 2023
bengotow
pushed a commit
that referenced
this pull request
Dec 14, 2023
When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. Previously, we disabled this option when “scope=selection” because there was no confirmation modal and it was confusing whether it would use your selection or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing. I audited all the callsites where we use the LaunchAssetExecutionButton, and the only places we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place.
bengotow
pushed a commit
that referenced
this pull request
Dec 14, 2023
When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. Previously, we disabled this option when “scope=selection” because there was no confirmation modal and it was confusing whether it would use your selection or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing. I audited all the callsites where we use the LaunchAssetExecutionButton, and the only places we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place.
bengotow
pushed a commit
that referenced
this pull request
Jan 1, 2024
When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. Previously, we disabled this option when “scope=selection” because there was no confirmation modal and it was confusing whether it would use your selection or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing. I audited all the callsites where we use the LaunchAssetExecutionButton, and the only places we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place.
bengotow
added a commit
that referenced
this pull request
Jan 2, 2024
…8722) When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. This PR reverts a bit of #18198 so it appears here: <img width="1727" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/5d1df552-dcd1-4d05-93d7-6d16f320637b"> Previously, we disabled this option when `scope=selection` because there was no confirmation modal and it was confusing whether it was "changed and missing and in your selection" or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing and we should offer it in this case. I audited all the callsites where we use the LaunchAssetExecutionButton, and I think the only place we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place. ## How I Tested These Changes I verified the existing tests covering the launch button still pass, and tested these changes manually in the graph and list view. --------- Co-authored-by: bengotow <[email protected]>
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jan 6, 2024
…gster-io#18722) When we revamped the data loading in the global asset graph, we limited the “materialize changed and missing” to specific contexts (dagster-io#18198). I think that it makes sense to show this option whenever more than one asset is in scope, whether you’re operating on an all assets in view or on a selection. This PR reverts a bit of dagster-io#18198 so it appears here: <img width="1727" alt="image" src="https://github.com/dagster-io/dagster/assets/1037212/5d1df552-dcd1-4d05-93d7-6d16f320637b"> Previously, we disabled this option when `scope=selection` because there was no confirmation modal and it was confusing whether it was "changed and missing and in your selection" or not. Now that we have a nice modal with checkboxes for revising + confirming the subset that will materialize, it’s no longer confusing and we should offer it in this case. I audited all the callsites where we use the LaunchAssetExecutionButton, and I think the only place we don’t want to show this option is on the individual asset view. To make sure this doesn’t get left out again, I inverted the option from “showChangedAndMissingOption” (show option) to “scopeAlwaysSingleAsset” (hide option) and set it in just that one place. ## How I Tested These Changes I verified the existing tests covering the launch button still pass, and tested these changes manually in the graph and list view. --------- Co-authored-by: bengotow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We used to rely on a field called
liveDataForStaleto determine whether or not to show this option. Since we stopped fetching all of the live data upfront we removed that attribute but as a consequence we also removed the gating of the changed and missing feature. This PR adds back that gating by introducing a new prop:showChangedAndMissingOptionHow I Tested These Changes
locally