-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amp-refactor][4/n] AssetAutomationCondition -> AssetCondition #18615
Merged
OwenKephart
merged 1 commit into
master
from
12-08-AssetAutomationCondition_-_AssetCondition
Jan 19, 2024
Merged
[amp-refactor][4/n] AssetAutomationCondition -> AssetCondition #18615
OwenKephart
merged 1 commit into
master
from
12-08-AssetAutomationCondition_-_AssetCondition
Jan 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 11, 2023 19:41
e3f0911
to
d7dbf82
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
5 times, most recently
from
December 11, 2023 20:04
215a1aa
to
43ba8a9
Compare
This was referenced Dec 12, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 13, 2023 17:14
d7dbf82
to
538f7d6
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
December 13, 2023 17:14
43ba8a9
to
4742f39
Compare
This was referenced Dec 13, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 16, 2023 00:36
538f7d6
to
9e94345
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
December 16, 2023 00:36
4742f39
to
ea52277
Compare
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 18, 2023 21:44
9e94345
to
5566260
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
December 18, 2023 21:44
ea52277
to
9bb58c1
Compare
This was referenced Dec 18, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 19, 2023 23:19
5566260
to
2898ff4
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
December 19, 2023 23:19
9bb58c1
to
922ec6a
Compare
sryza
approved these changes
Dec 21, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
December 29, 2023 18:52
2898ff4
to
6a36adc
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
December 29, 2023 18:52
922ec6a
to
97551af
Compare
This was referenced Dec 29, 2023
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 8, 2024 20:39
6a36adc
to
40f967e
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 8, 2024 20:39
97551af
to
90b320e
Compare
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 9, 2024 17:07
40f967e
to
3037dfd
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 9, 2024 17:07
90b320e
to
8f515de
Compare
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 12, 2024 13:58
3037dfd
to
dff0a9c
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 12, 2024 13:58
8f515de
to
b56a236
Compare
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 17, 2024 23:10
dff0a9c
to
45a3173
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 17, 2024 23:10
b56a236
to
75cf296
Compare
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 18, 2024 23:16
45a3173
to
643167c
Compare
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 18, 2024 23:16
75cf296
to
d6143ec
Compare
Merge activity
|
OwenKephart
force-pushed
the
12-08-RuleEvaluationData_-_SubsetWithMetadata
branch
from
January 19, 2024 21:22
643167c
to
0f75720
Compare
Base automatically changed from
12-08-RuleEvaluationData_-_SubsetWithMetadata
to
master
January 19, 2024 21:24
OwenKephart
force-pushed
the
12-08-AssetAutomationCondition_-_AssetCondition
branch
from
January 19, 2024 21:25
d6143ec
to
1ebb29c
Compare
OwenKephart
deleted the
12-08-AssetAutomationCondition_-_AssetCondition
branch
January 19, 2024 21:26
PedramNavid
pushed a commit
that referenced
this pull request
Jan 26, 2024
## Summary & Motivation This PR renames some classes to get them closer to the final form. In this case, we rename AutomationCondition to AssetCondition, which has knock-on effects for things such as the context objects. This also gets rid of the now-redundant AutomationPolicyEvaluator class ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This PR renames some classes to get them closer to the final form. In this case, we rename AutomationCondition to AssetCondition, which has knock-on effects for things such as the context objects.
This also gets rid of the now-redundant AutomationPolicyEvaluator class
How I Tested These Changes