Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-refactor][4/n] AssetAutomationCondition -> AssetCondition #18615

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

This PR renames some classes to get them closer to the final form. In this case, we rename AutomationCondition to AssetCondition, which has knock-on effects for things such as the context objects.

This also gets rid of the now-redundant AutomationPolicyEvaluator class

How I Tested These Changes

@OwenKephart
Copy link
Contributor Author

OwenKephart commented Dec 8, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@OwenKephart OwenKephart requested a review from sryza December 8, 2023 22:12
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from e3f0911 to d7dbf82 Compare December 11, 2023 19:41
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch 5 times, most recently from 215a1aa to 43ba8a9 Compare December 11, 2023 20:04
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from d7dbf82 to 538f7d6 Compare December 13, 2023 17:14
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 43ba8a9 to 4742f39 Compare December 13, 2023 17:14
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 538f7d6 to 9e94345 Compare December 16, 2023 00:36
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 4742f39 to ea52277 Compare December 16, 2023 00:36
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 9e94345 to 5566260 Compare December 18, 2023 21:44
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from ea52277 to 9bb58c1 Compare December 18, 2023 21:44
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 5566260 to 2898ff4 Compare December 19, 2023 23:19
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 9bb58c1 to 922ec6a Compare December 19, 2023 23:19
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 2898ff4 to 6a36adc Compare December 29, 2023 18:52
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 922ec6a to 97551af Compare December 29, 2023 18:52
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 6a36adc to 40f967e Compare January 8, 2024 20:39
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 97551af to 90b320e Compare January 8, 2024 20:39
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 40f967e to 3037dfd Compare January 9, 2024 17:07
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 90b320e to 8f515de Compare January 9, 2024 17:07
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 3037dfd to dff0a9c Compare January 12, 2024 13:58
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 8f515de to b56a236 Compare January 12, 2024 13:58
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from dff0a9c to 45a3173 Compare January 17, 2024 23:10
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from b56a236 to 75cf296 Compare January 17, 2024 23:10
@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 45a3173 to 643167c Compare January 18, 2024 23:16
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from 75cf296 to d6143ec Compare January 18, 2024 23:16
@OwenKephart
Copy link
Contributor Author

OwenKephart commented Jan 19, 2024

Merge activity

  • Jan 19, 4:20 PM: @OwenKephart started a stack merge that includes this pull request via Graphite.
  • Jan 19, 4:25 PM: Graphite rebased this pull request as part of a merge.
  • Jan 19, 4:26 PM: @OwenKephart merged this pull request with Graphite.

@OwenKephart OwenKephart force-pushed the 12-08-RuleEvaluationData_-_SubsetWithMetadata branch from 643167c to 0f75720 Compare January 19, 2024 21:22
Base automatically changed from 12-08-RuleEvaluationData_-_SubsetWithMetadata to master January 19, 2024 21:24
@OwenKephart OwenKephart force-pushed the 12-08-AssetAutomationCondition_-_AssetCondition branch from d6143ec to 1ebb29c Compare January 19, 2024 21:25
@OwenKephart OwenKephart merged commit 596d690 into master Jan 19, 2024
1 check was pending
@OwenKephart OwenKephart deleted the 12-08-AssetAutomationCondition_-_AssetCondition branch January 19, 2024 21:26
PedramNavid pushed a commit that referenced this pull request Jan 26, 2024
## Summary & Motivation

This PR renames some classes to get them closer to the final form. In this case, we rename AutomationCondition to AssetCondition, which has knock-on effects for things such as the context objects.

This also gets rid of the now-redundant AutomationPolicyEvaluator class

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants