Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[amp-refactor][?/n] Add asset_condition argument to AssetsDefinition and friends #18802

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

The plan is to allow users to supply AssetCondition objects instead of AutoMaterializePolicies. This PR makes that happen by turning the AutoMaterializePolicy class into a shell whose only purpose is to generate AssetConditions.

This meant that it had to be removed at the storage layer as well, as we want external asset nodes to be able to store regular AssetConditions. Luckily, it's fairly easy to ensure that AutoMaterializePolicies get deserialized as AssetConditions, as we already had some customized serialization going on in that part of the world.

How I Tested These Changes

@OwenKephart
Copy link
Contributor Author

OwenKephart commented Dec 18, 2023

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 1f38134 to 8ca46fd Compare December 18, 2023 22:59
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 0dd3369 to cf30630 Compare December 19, 2023 23:19
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 8ca46fd to 0d547d4 Compare December 19, 2023 23:19
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from cf30630 to 7f8a5f4 Compare December 21, 2023 20:49
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 7f8a5f4 to a8629aa Compare December 29, 2023 15:30
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 0d547d4 to 88f5a9a Compare December 29, 2023 15:30
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from a8629aa to 21a936e Compare December 29, 2023 18:52
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 88f5a9a to a3e232e Compare December 29, 2023 18:52
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 21a936e to d602281 Compare December 29, 2023 20:32
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from a3e232e to abc3927 Compare December 29, 2023 20:32
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from d602281 to 063c290 Compare December 29, 2023 20:58
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from abc3927 to 7215ad2 Compare December 29, 2023 20:58
@OwenKephart OwenKephart changed the title [amp-refactor][10/n] Add asset_condition argument to AssetsDefinition and friends [amp-refactor][?/n] Add asset_condition argument to AssetsDefinition and friends Dec 29, 2023
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch 4 times, most recently from 5e0751f to 7b1680f Compare January 4, 2024 13:46
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 7b1680f to 8a51001 Compare January 4, 2024 15:59
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 8a51001 to 55ffe29 Compare January 8, 2024 20:39
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 7215ad2 to d0ba4df Compare January 8, 2024 20:40
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 55ffe29 to aee24f6 Compare January 9, 2024 17:08
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from d0ba4df to a943b62 Compare January 9, 2024 17:08
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from aee24f6 to 794ef38 Compare January 11, 2024 22:21
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from a943b62 to 5d3635c Compare January 11, 2024 22:21
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 794ef38 to a666900 Compare January 11, 2024 23:09
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 5d3635c to e2eef99 Compare January 11, 2024 23:09
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch 2 times, most recently from 7ba378c to ba6e90e Compare January 12, 2024 13:58
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from e2eef99 to e5551f7 Compare January 12, 2024 13:58
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from ba6e90e to 3be95a8 Compare January 12, 2024 16:56
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from e5551f7 to 25cabc4 Compare January 12, 2024 16:56
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch from 3be95a8 to 808ad3c Compare January 12, 2024 18:01
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 25cabc4 to 8ea75c2 Compare January 12, 2024 18:02
@OwenKephart OwenKephart force-pushed the 12-15-Better_cursor_handling branch 3 times, most recently from 65b4079 to e0f49ab Compare January 19, 2024 21:34
Base automatically changed from 12-15-Better_cursor_handling to master January 19, 2024 21:36
@OwenKephart OwenKephart force-pushed the 12-18-Add_asset_condition_argument_to_AssetsDefinition_etal branch from 8ea75c2 to 41d3d8c Compare February 7, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant