Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io managers] remove special casing for Nothing outputs in io managers #18767

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Dec 15, 2023

Summary & Motivation

Our custom I/O managers have special cases written in that raise exceptions when an output is typed as Nothing. #18448 moves this logic of skipping the I/O manager so the main execution code path, so we can remove these special cases for the I/O managers. For DB I/O managers, we still need to raise an error when the return is None but doesn't have a Nothing typing type for consistency across versions.

How I Tested These Changes

@jamiedemaria jamiedemaria force-pushed the jamie/skip-io-on-nothing branch from 3e4aa2a to 4441f87 Compare December 18, 2023 21:40
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from 69ef797 to 11346c1 Compare December 18, 2023 21:40
@jamiedemaria jamiedemaria force-pushed the jamie/skip-io-on-nothing branch from 4441f87 to cbb85e0 Compare December 19, 2023 21:32
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from 11346c1 to 9569d69 Compare December 19, 2023 21:33
@jamiedemaria jamiedemaria force-pushed the jamie/skip-io-on-nothing branch from cbb85e0 to 33a5d59 Compare December 27, 2023 17:56
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from 9569d69 to bb786c6 Compare December 27, 2023 17:56
@jamiedemaria jamiedemaria force-pushed the jamie/skip-io-on-nothing branch from 33a5d59 to a9f7ba4 Compare January 2, 2024 20:02
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from bb786c6 to e3d8b45 Compare January 2, 2024 20:02
@jamiedemaria jamiedemaria force-pushed the jamie/skip-io-on-nothing branch from a9f7ba4 to c0c2eda Compare January 2, 2024 21:10
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from e3d8b45 to 84b4a93 Compare January 2, 2024 21:10
@jamiedemaria jamiedemaria marked this pull request as ready for review January 3, 2024 17:13
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch 2 times, most recently from 0feb74a to 5d54603 Compare January 4, 2024 00:09
Base automatically changed from jamie/skip-io-on-nothing to master January 4, 2024 16:07
@jamiedemaria jamiedemaria force-pushed the jamie/remove-nothing-special-casing branch from 5d54603 to 2ed484a Compare January 4, 2024 16:08
@jamiedemaria jamiedemaria merged commit 5cfefb6 into master Jan 4, 2024
1 check passed
@jamiedemaria jamiedemaria deleted the jamie/remove-nothing-special-casing branch January 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants