-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[io managers] remove special casing for Nothing outputs in io managers #18767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 15, 2023
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
jamiedemaria
force-pushed
the
jamie/skip-io-on-nothing
branch
from
December 18, 2023 21:40
3e4aa2a
to
4441f87
Compare
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
December 18, 2023 21:40
69ef797
to
11346c1
Compare
jamiedemaria
commented
Dec 19, 2023
jamiedemaria
commented
Dec 19, 2023
jamiedemaria
commented
Dec 19, 2023
jamiedemaria
force-pushed
the
jamie/skip-io-on-nothing
branch
from
December 19, 2023 21:32
4441f87
to
cbb85e0
Compare
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
December 19, 2023 21:33
11346c1
to
9569d69
Compare
jamiedemaria
force-pushed
the
jamie/skip-io-on-nothing
branch
from
December 27, 2023 17:56
cbb85e0
to
33a5d59
Compare
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
December 27, 2023 17:56
9569d69
to
bb786c6
Compare
jamiedemaria
force-pushed
the
jamie/skip-io-on-nothing
branch
from
January 2, 2024 20:02
33a5d59
to
a9f7ba4
Compare
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
January 2, 2024 20:02
bb786c6
to
e3d8b45
Compare
jamiedemaria
force-pushed
the
jamie/skip-io-on-nothing
branch
from
January 2, 2024 21:10
a9f7ba4
to
c0c2eda
Compare
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
January 2, 2024 21:10
e3d8b45
to
84b4a93
Compare
alangenfeld
approved these changes
Jan 3, 2024
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
2 times, most recently
from
January 4, 2024 00:09
0feb74a
to
5d54603
Compare
yuhan
approved these changes
Jan 4, 2024
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
January 4, 2024 16:08
5d54603
to
2ed484a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Our custom I/O managers have special cases written in that raise exceptions when an output is typed as
Nothing
. #18448 moves this logic of skipping the I/O manager so the main execution code path, so we can remove these special cases for the I/O managers. For DB I/O managers, we still need to raise an error when the return isNone
but doesn't have aNothing
typing type for consistency across versions.How I Tested These Changes