[do not merge] Provide upstream asset materialization events to currently materializing asset #18916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
dc32768 to
1922411
Compare
jamiedemaria
changed the base branch from
master
to
jamie/remove-nothing-special-casing
This was referenced Dec 28, 2023
jamiedemaria
changed the title
jamiedemaria
changed the title
jamiedemaria
force-pushed
the
jamie/remove-nothing-special-casing
branch
from
bb786c6 to
e3d8b45
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
70b8610 to
9051a62
Compare
jamiedemaria
changed the base branch from
jamie/remove-nothing-special-casing
to
jamie/upath-return-none-when-no-file
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
7b3e547 to
d225e92
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
3 times, most recently
from
56a2790 to
047325b
Compare
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
cc86d44 to
482da77
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
047325b to
75d69d2
Compare
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
482da77 to
bf99217
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
75d69d2 to
b7aba1e
Compare
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
bf99217 to
7c09193
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
b7aba1e to
3f1cf4e
Compare
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
7c09193 to
8bd5fe7
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
3f1cf4e to
19eee0e
Compare
jamiedemaria
force-pushed
the
jamie/upath-return-none-when-no-file
branch
from
8bd5fe7 to
41070f0
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
19eee0e to
963ec15
Compare
jamiedemaria
force-pushed
the
jamie/upstream-metadata
branch
from
963ec15 to
1141833
Compare
jamiedemaria
changed the base branch from
jamie/upath-return-none-when-no-file
to
master
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 1141833. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 1141833. |
jamiedemaria
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Piggybacks on the data version computations to maintain a dictionary of the latest
AssetMaterializationfor all of the upstream dependencies for a materializing asset. This allows us to provide the asset materialization for an upstream asset in the compute function. In turn this provides access to metadataHow I Tested These Changes