Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[external-assets] External asset renames #19741

Closed
wants to merge 1 commit into from
Closed

[external-assets] External asset renames #19741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python_modules/dagster/dagster/_core/definitions/asset_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
from dagster._core.errors import DagsterInvalidSubsetError
from dagster._core.selector.subset_selector import (
fetch_connected,
fetch_roots,
fetch_sinks,
fetch_sources,
parse_clause,
)
from dagster._core.storage.tags import TAG_NO_VALUE
Expand Down Expand Up @@ -748,7 +748,7 @@ def resolve_inner(
self, asset_graph: BaseAssetGraph, allow_missing: bool
) -> AbstractSet[AssetKey]:
selection = self.child.resolve_inner(asset_graph, allow_missing=allow_missing)
return fetch_sources(asset_graph.asset_dep_graph, selection)
return fetch_roots(asset_graph.asset_dep_graph, selection)

def to_serializable_asset_selection(self, asset_graph: BaseAssetGraph) -> "AssetSelection":
return self.replace(child=self.child.to_serializable_asset_selection(asset_graph))
Expand Down
4 changes: 2 additions & 2 deletions python_modules/dagster/dagster/_core/selector/subset_selector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,10 +243,10 @@ def fetch_sinks(
return sinks


def fetch_sources(
def fetch_roots(
graph: DependencyGraph[T_Hashable], within_selection: AbstractSet[T_Hashable]
) -> AbstractSet[T_Hashable]:
"""A source is a node that has no upstream dependencies within the provided selection.
"""A root is a node that has no upstream dependencies within the provided selection.
It can have other dependencies outside of the selection.
"""
dp: Dict[T_Hashable, bool] = {}
Expand Down