[external-assets] External asset renames #19741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @smackesey and the rest of your teammates on |
This was referenced Feb 12, 2024
smackesey
force-pushed
the
sean/remove-source-asset-from-jobs
branch
2 times, most recently
from
5b214ac to
3bfbef8
Compare
This was referenced Feb 13, 2024
Merged
schrockn
requested changes
Feb 13, 2024
smackesey
force-pushed
the
sean/remove-source-asset-from-jobs
branch
from
3bfbef8 to
05b414b
Compare
smackesey
force-pushed
the
sean/external-assets-renames
branch
from
da95774 to
922d8ee
Compare
|
Superseded by another stack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Renames of internal methods using "source" or "non_source" to their respective "external" and "materializable" equivalents. In some cases "source" was also renamed to "root", when "source" was used not to mean
SourceAssetbut rather "root of an asset selection" (we already use "root" terminology inAssetSelection).How I Tested These Changes
Existing test suite.