[ui] IA flagged changes to navigation #20971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
|
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit b94b764. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b94b764. |
hellendag
force-pushed
the
dish/flagged-top-nav
branch
from
cad90be to
c6356be
Compare
hellendag
force-pushed
the
dish/flagged-top-nav
branch
from
c6356be to
b94b764
Compare
salazarm
approved these changes
Apr 3, 2024
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Apply changes to the top nav for our info architecture exploration, along with some stylistic changes to the top right side of the nav to make it more consistent.
Non-flagged:
With settings flag:
How I Tested These Changes
Load app, verify top nav rendering and behavior. Enable new Settings flag, verify same.