[ui] Add tooltip with keyboard shortcut info on top nav items #20977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @hellendag and the rest of your teammates on |
salazarm
reviewed
Apr 2, 2024
| @@ -42,8 +42,7 @@ export const AppTopNav = ({children, allowGlobalReload = false}: Props) => { | |||
| } | |||
| }} | |||
| shortcutLabel={`⌥R - ${reloading ? 'Reloading' : 'Reload all code locations'}`} | |||
| // On OSX Alt + R creates ®, not sure about windows, so checking 'r' for windows | |||
| shortcutFilter={(e) => e.altKey && (e.key === '®' || e.key === 'r')} | |||
| shortcutFilter={(e) => e.altKey && e.code === 'KeyR'} | |||
salazarm
approved these changes
Apr 2, 2024
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit b590d3b. |
bengotow
approved these changes
Apr 2, 2024
hellendag
force-pushed
the
dish/flagged-top-nav
branch
from
c6356be to
b94b764
Compare
hellendag
force-pushed
the
dish/search-tooltip
branch
from
c835d58 to
7a6bbe4
Compare
Merge activity
|
hellendag
force-pushed
the
dish/search-tooltip
branch
from
7a6bbe4 to
b590d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add a tooltip with info about keyboard shortcuts on Search and Help buttons.
How I Tested These Changes
View top nav in app, hover on these buttons.