feat(looker): add scaffold for dagster-looker
#21284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
rexledesma
force-pushed
the
rl/scaffold-dagster-looker-python-package
branch
from
b56dd91 to
20d9988
Compare
|
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-gf2mrbsgl-elementl.vercel.app Direct link to changed pages: |
|
+1 to adding a scaffold. @rexledesma - any particular aspects of this you're looking for review on? |
rexledesma
force-pushed
the
rl/scaffold-dagster-looker-python-package
branch
from
20d9988 to
7956a99
Compare
This was referenced Apr 18, 2024
rexledesma
force-pushed
the
rl/scaffold-dagster-looker-python-package
branch
from
7956a99 to
888873f
Compare
benpankow
reviewed
Apr 26, 2024
python_modules/libraries/dagster-looker/dagster_looker/version.py
Outdated
Show resolved
Hide resolved
rexledesma
force-pushed
the
rl/scaffold-dagster-looker-python-package
branch
2 times, most recently
from
c49ac87 to
3dc04b6
Compare
benpankow
approved these changes
May 1, 2024
| Looker (dagster-looker) | ||
| ----------------------------------------------------- | ||
|
|
||
| .. TODO description |
There was a problem hiding this comment.
Might be worth putting off the apidoc addition until we add version.py so the module is published same time as the docs - otherwise we should fill out a desc here
rexledesma
force-pushed
the
rl/scaffold-dagster-looker-python-package
branch
from
3dc04b6 to
bfc7894
Compare
cmpadden
pushed a commit
that referenced
this pull request
May 6, 2024
## Summary & Motivation As the title. Separating this out from filling out the core business logic. Some things to figure out before landing: - Remove `dagster-looker` from the release pipeline until everything is tested end-to-end. ## How I Tested These Changes `python scripts/create_dagster_package.py -n dagster-looker`
rexledesma
added a commit
that referenced
this pull request
May 14, 2024
## Summary & Motivation Undo #21284 (comment). ## How I Tested These Changes N/A
alangenfeld
pushed a commit
that referenced
this pull request
May 14, 2024
## Summary & Motivation Undo #21284 (comment). ## How I Tested These Changes N/A
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…1810) ## Summary & Motivation Undo dagster-io#21284 (comment). ## How I Tested These Changes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
As the title. Separating this out from filling out the core business logic.
Some things to figure out before landing:
dagster-lookerfrom the release pipeline until everything is tested end-to-end.How I Tested These Changes
python scripts/create_dagster_package.py -n dagster-looker