Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(looker): add retail_demo project #21293

Merged
merged 2 commits into from
May 2, 2024

Conversation

rexledesma
Copy link
Contributor

@rexledesma rexledesma commented Apr 18, 2024

Summary & Motivation

Copy a subset of https://github.com/looker-open-source/retail_demo for unit testing. Included the license as well.

How I Tested These Changes

See downstream PRs.

Copy link
Contributor Author

rexledesma commented Apr 18, 2024

Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert on this stuff, but I think we might need to include the license from the repo that we're copying this from.

@rexledesma rexledesma force-pushed the rl/scaffold-dagster-looker-python-package branch from 7956a99 to 888873f Compare April 19, 2024 14:22
@rexledesma rexledesma force-pushed the rl/scaffold-looker-sample-project branch from 4790d9a to a9b4e6b Compare April 19, 2024 14:22
@rexledesma rexledesma requested a review from sryza April 19, 2024 14:23
@rexledesma rexledesma force-pushed the rl/scaffold-dagster-looker-python-package branch from 888873f to c49ac87 Compare April 30, 2024 14:47
@rexledesma rexledesma force-pushed the rl/scaffold-looker-sample-project branch from a9b4e6b to 62192af Compare April 30, 2024 14:47
@graphite-app graphite-app bot added the area: docs Related to documentation in general label Apr 30, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 April 30, 2024 14:48
@rexledesma rexledesma force-pushed the rl/scaffold-dagster-looker-python-package branch from c49ac87 to 3dc04b6 Compare April 30, 2024 14:48
@rexledesma rexledesma force-pushed the rl/scaffold-looker-sample-project branch from 62192af to 46a7317 Compare April 30, 2024 14:48
@rexledesma rexledesma force-pushed the rl/scaffold-dagster-looker-python-package branch from 3dc04b6 to bfc7894 Compare May 2, 2024 13:53
@rexledesma rexledesma force-pushed the rl/scaffold-looker-sample-project branch from 46a7317 to 9a5eedc Compare May 2, 2024 13:53
Base automatically changed from rl/scaffold-dagster-looker-python-package to master May 2, 2024 14:38
@rexledesma rexledesma requested review from benpankow and removed request for prha and erinkcochran87 May 2, 2024 15:30
Copy link
Member

@benpankow benpankow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are some changes to the dagster_looker boilerplate showing up here too, maybe needs a rebase?

@rexledesma rexledesma force-pushed the rl/scaffold-looker-sample-project branch from 9a5eedc to 5d0401c Compare May 2, 2024 16:35
@rexledesma rexledesma merged commit d1ad40c into master May 2, 2024
1 check passed
@rexledesma rexledesma deleted the rl/scaffold-looker-sample-project branch May 2, 2024 16:48
Copy link
Contributor Author

Merge activity

cmpadden pushed a commit that referenced this pull request May 6, 2024
## Summary & Motivation
Copy a subset of https://github.com/looker-open-source/retail_demo for unit testing. Included the license as well.

## How I Tested These Changes
See downstream PRs.
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation
Copy a subset of https://github.com/looker-open-source/retail_demo for unit testing. Included the license as well.

## How I Tested These Changes
See downstream PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants