[docs] Add guide for code references #21755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
benpankow
commented
May 9, 2024
| @@ -1159,13 +1159,13 @@ | |||
| { | |||
| "title": "Experimental features", | |||
| "children": [ | |||
| { | |||
There was a problem hiding this comment.
deprecated, so dropping
There was a problem hiding this comment.
not a huge deal, but ideally would do this in a separate PR where we also drop the mdx and python files
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
7277f74 to
7ea5960
Compare
sryza
reviewed
May 15, 2024
sryza
reviewed
May 15, 2024
| assets=with_source_code_references( | ||
| [ | ||
| my_asset, | ||
| another_asset, |
There was a problem hiding this comment.
taking away the comma at the end of this line would allow this snippet to condense more
| @@ -1159,13 +1159,13 @@ | |||
| { | |||
| "title": "Experimental features", | |||
| "children": [ | |||
| { | |||
There was a problem hiding this comment.
not a huge deal, but ideally would do this in a separate PR where we also drop the mdx and python files
| file_path=os.path.join( | ||
| os.path.dirname(__file__), "source.yaml" | ||
| ), | ||
| line_number=1, |
There was a problem hiding this comment.
This makes me think we should make line_number optional
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
48eb1b8 to
62219d7
Compare
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
62219d7 to
739c3fa
Compare
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
739c3fa to
82dd9b7
Compare
This was referenced Jun 6, 2024
benpankow
force-pushed
the
benpankow/guide-code-references
branch
2 times, most recently
from
b600ef7 to
f3423f1
Compare
rexledesma
suggested changes
Jun 11, 2024
|
This is ready for review on content, will need to update the screenshots since the design has changed a little |
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
f3423f1 to
37567b6
Compare
rexledesma
approved these changes
Jun 11, 2024
docs/next/public/images/guides/code-references/manual_references.png
Outdated
Show resolved
Hide resolved
benpankow
force-pushed
the
benpankow/guide-code-references
branch
3 times, most recently
from
d833a1c to
b8f570e
Compare
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
b8f570e to
9ff3f56
Compare
Merge activity
|
benpankow
force-pushed
the
benpankow/guide-code-references
branch
from
9ff3f56 to
c8a8df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add guide for basic local code references functionality. Will stack PR for source control references, when ready.
Test Plan
viewed locally
https://benpankow-guide-code-references.dagster.dagster-docs.io/guides/dagster/code-references