Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add dbt code references guide #22318

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

benpankow
Copy link
Member

Summary

Brief expansion of the code references guide to include info on generating dbt code references.

Test Plan

vercel

@graphite-app graphite-app bot added the area: docs Related to documentation in general label Jun 6, 2024
@graphite-app graphite-app bot requested a review from erinkcochran87 June 6, 2024 15:05
@benpankow
Copy link
Member Author

benpankow commented Jun 6, 2024

@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from 305e92c to 918f3c4 Compare June 6, 2024 15:11
@benpankow benpankow requested a review from sryza June 6, 2024 15:12
sryza
sryza previously requested changes Jun 7, 2024
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with how we treat the dbt facets of other features, I think this should go in the dbt reference page, instead of here.

)

from dagster import AssetExecutionContext, Definitions
from dagster._core.definitions.metadata import with_source_code_references
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't put any private imports in docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is just for demonstration purposes until we expose these apis publicly - will do another pass once we do so

@benpankow benpankow force-pushed the benpankow/guide-code-references branch from d4e8f7b to b600ef7 Compare June 7, 2024 17:30
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from 875b084 to ac47dcd Compare June 7, 2024 17:30
@benpankow
Copy link
Member Author

Updated, moved to dbt docs w/ link from references guide

@benpankow benpankow requested a review from sryza June 7, 2024 17:37
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from b600ef7 to f3423f1 Compare June 7, 2024 22:06
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from f4e6d8e to 6ce81f3 Compare June 7, 2024 22:06
Copy link
Contributor

@sryza sryza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-dbt parts need to wait until the utility function is exposed publicly, but the section in the dbt reference could be merged now.

docs/content/integrations/dbt/reference.mdx Outdated Show resolved Hide resolved
docs/content/integrations/dbt/reference.mdx Outdated Show resolved Hide resolved
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from f3423f1 to 37567b6 Compare June 11, 2024 16:03
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from 37567b6 to 20e4020 Compare July 2, 2024 18:13
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from 6ce81f3 to 0cac947 Compare July 2, 2024 18:13
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from 20e4020 to d833a1c Compare July 2, 2024 20:04
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from 0cac947 to acff923 Compare July 2, 2024 20:04
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from d833a1c to b8f570e Compare July 3, 2024 20:46
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from acff923 to 2f34c5b Compare July 3, 2024 20:46
@benpankow benpankow force-pushed the benpankow/guide-code-references branch from b8f570e to 9ff3f56 Compare July 8, 2024 20:33
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from b63910d to ae49538 Compare July 8, 2024 20:33
@benpankow
Copy link
Member Author

benpankow commented Jul 8, 2024

Merge activity

  • Jul 8, 1:45 PM PDT: @benpankow started a stack merge that includes this pull request via Graphite.
  • Jul 8, 1:48 PM PDT: Graphite rebased this pull request as part of a merge.
  • Jul 8, 1:49 PM PDT: @benpankow merged this pull request with Graphite.

@benpankow benpankow force-pushed the benpankow/guide-code-references branch from 9ff3f56 to c8a8df7 Compare July 8, 2024 20:46
Base automatically changed from benpankow/guide-code-references to master July 8, 2024 20:47
@benpankow benpankow force-pushed the benpankow/guide-code-references-dbt branch from ae49538 to 87722d6 Compare July 8, 2024 20:47
@benpankow benpankow merged commit 4b30462 into master Jul 8, 2024
1 of 2 checks passed
@benpankow benpankow deleted the benpankow/guide-code-references-dbt branch July 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to documentation in general
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants