-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] add dbt code references guide #22318
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on Graphite |
305e92c
to
918f3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with how we treat the dbt facets of other features, I think this should go in the dbt reference page, instead of here.
) | ||
|
||
from dagster import AssetExecutionContext, Definitions | ||
from dagster._core.definitions.metadata import with_source_code_references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't put any private imports in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is just for demonstration purposes until we expose these apis publicly - will do another pass once we do so
d4e8f7b
to
b600ef7
Compare
875b084
to
ac47dcd
Compare
Updated, moved to dbt docs w/ link from references guide |
b600ef7
to
f3423f1
Compare
f4e6d8e
to
6ce81f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-dbt parts need to wait until the utility function is exposed publicly, but the section in the dbt reference could be merged now.
f3423f1
to
37567b6
Compare
37567b6
to
20e4020
Compare
6ce81f3
to
0cac947
Compare
20e4020
to
d833a1c
Compare
0cac947
to
acff923
Compare
d833a1c
to
b8f570e
Compare
acff923
to
2f34c5b
Compare
b8f570e
to
9ff3f56
Compare
b63910d
to
ae49538
Compare
Merge activity
|
9ff3f56
to
c8a8df7
Compare
ae49538
to
87722d6
Compare
Summary
Brief expansion of the code references guide to include info on generating dbt code references.
Test Plan
vercel