refactor(looker): build dashboard specs in a utility function #21833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2024
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
91e25d1 to
00af07a
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
rexledesma
force-pushed
the
rl/add-looker-api-docs
branch
from
5776976 to
1af4b5d
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
00af07a to
decd116
Compare
rexledesma
force-pushed
the
rl/add-looker-api-docs
branch
from
1af4b5d to
c6d8a68
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
2 times, most recently
from
e3e69a4 to
074d5af
Compare
rexledesma
force-pushed
the
rl/add-looker-api-docs
branch
from
c6d8a68 to
04012ed
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
074d5af to
66b4808
Compare
Merge activity
|
alangenfeld
pushed a commit
that referenced
this pull request
May 14, 2024
## Summary & Motivation Addresses #21687 (comment). ## How I Tested These Changes pytest
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…r-io#21833) ## Summary & Motivation Addresses dagster-io#21687 (comment). ## How I Tested These Changes pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Addresses #21687 (comment).
How I Tested These Changes
pytest