feat(looker): allow customization of AssetKey through DagsterLookerTranslator
#21835
+130
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexledesma
requested review from
benpankow and
sryza
and removed request for
erinkcochran87
This was referenced May 14, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @rexledesma and the rest of your teammates on |
rexledesma
removed
the
area: docs
Graphite App
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
00af07a to
decd116
Compare
rexledesma
force-pushed
the
rl/add-dagster-looker-translator
branch
from
a8be18d to
93c9b6d
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
decd116 to
e3e69a4
Compare
rexledesma
force-pushed
the
rl/add-dagster-looker-translator
branch
from
93c9b6d to
0ab06cd
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
e3e69a4 to
074d5af
Compare
rexledesma
force-pushed
the
rl/add-dagster-looker-translator
branch
from
0ab06cd to
f2cc6fb
Compare
rexledesma
force-pushed
the
rl/refactor-dashboard-specs-to-utils
branch
from
074d5af to
66b4808
Compare
rexledesma
force-pushed
the
rl/add-dagster-looker-translator
branch
from
f2cc6fb to
d591601
Compare
Merge activity
|
alangenfeld
pushed a commit
that referenced
this pull request
May 14, 2024
…rTranslator` (#21835) ## Summary & Motivation Introduce a similar pattern to `DagsterDbtTranslator` to allow the user to customize asset keys. Next up, we'll allow the user to customize group name, tags, etc. ## How I Tested These Changes pytest
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…rTranslator` (dagster-io#21835) ## Summary & Motivation Introduce a similar pattern to `DagsterDbtTranslator` to allow the user to customize asset keys. Next up, we'll allow the user to customize group name, tags, etc. ## How I Tested These Changes pytest
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…erTranslator` (dagster-io#21845) ## Summary & Motivation Same thing as dagster-io#21835, but for description, metadata, group name, owners, and tags. ## How I Tested These Changes pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Introduce a similar pattern to
DagsterDbtTranslatorto allow the user to customize asset keys.Next up, we'll allow the user to customize group name, tags, etc.
How I Tested These Changes
pytest