Add batch-writable PLANNED_ASSET_MATERIALIZATION_FAILURE and PLANNED_ASSET_MATERIALIZATION_SKIPPED events #23327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f06448d. |
gibsondan
force-pushed
the
newfailureevents
branch
4 times, most recently
from
1dffe88 to
da29775
Compare
gibsondan
changed the title
gibsondan
force-pushed
the
newfailureevents
branch
2 times, most recently
from
b6de440 to
a598183
Compare
gibsondan
force-pushed
the
newfailureevents
branch
6 times, most recently
from
3fcd11c to
677b697
Compare
gibsondan
commented
Aug 9, 2024
Comment on lines
250
to
+254
| values = self._get_asset_entry_values(event, event_id, self.has_asset_key_index_cols()) | ||
|
|
||
| if not values: | ||
| return | ||
|
|
There was a problem hiding this comment.
possible point of discussion - I am not currently updating the "last_run_id" or "last_materialization_timestamp" columns on this new event type, although i certainly could (both of those columns are currently updated on planned and materialization events)
It looks like the main place we use the timestamp column is in the context of wipes
gibsondan
force-pushed
the
newfailureevents
branch
3 times, most recently
from
bd15c13 to
2cacbad
Compare
gibsondan
force-pushed
the
eventlogstoragetests
branch
from
e6a803c to
6499e97
Compare
gibsondan
force-pushed
the
newfailureevents
branch
from
2cacbad to
43bdc22
Compare
gibsondan
force-pushed
the
eventlogstoragetests
branch
from
6499e97 to
61ac886
Compare
gibsondan
force-pushed
the
newfailureevents
branch
from
43bdc22 to
c3087c3
Compare
gibsondan
changed the title
gibsondan
force-pushed
the
newfailureevents
branch
from
c3087c3 to
7a9b38e
Compare
gibsondan
force-pushed
the
newfailureevents
branch
from
7a9b38e to
41c0a54
Compare
gibsondan
force-pushed
the
newfailureevents
branch
from
41c0a54 to
f06448d
Compare
prha
approved these changes
Aug 16, 2024
schrockn
reviewed
Sep 3, 2024
|
I am planning to merge this, yes. I was planning to get the stack working
end-to-end before doing so and got pulled into some other things.
…On Tue, Sep 3, 2024 at 6:23 AM Nick Schrock ***@***.***> wrote:
***@***.**** commented on this pull request.
Are you planning on merging this? Just cleaning up my PR queue.
—
Reply to this email directly, view it on GitHub
<#23327 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACAPJCYT7I5TD447724AD4TZUWL2DAVCNFSM6AAAAABLVJFYEOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZXGE2DSMZYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Doesn't actually add any write callsites yet, but provides the class and storage adjustments needed to write this event from either user code or a daemon.
How I Tested These Changes
BK (had to adjust the various TestEventLogSTorage subclasses to be able to access the instance)