Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch-writable PLANNED_ASSET_MATERIALIZATION_FAILURE and PLANNED_ASSET_MATERIALIZATION_SKIPPED events #23327

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

28 changes: 28 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/graphql/schema.graphql

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

99 changes: 99 additions & 0 deletions js_modules/dagster-ui/packages/ui-core/src/graphql/types.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ export const LogsRowStructuredContent = ({node, metadata}: IStructuredContentPro
/>
);
case 'AssetMaterializationPlannedEvent':
case 'PlannedAssetMaterializationFailureEvent':
case 'PlannedAssetMaterializationSkippedEvent':
return <DefaultContent eventType={eventType} message={node.message} />;
case 'ObjectStoreOperationEvent':
return (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,13 @@ import {weakmapMemoize} from '../app/Util';

export function filterLogs(logs: LogsProviderLogs, filter: LogFilter, filterStepKeys: string[]) {
const filteredNodes = logs.allNodes.filter((node) => {
// These events are used to determine which assets a run will materialize and are not intended
// These events are used for internal bookkeeping and are not intended
// to be displayed in the Dagster UI. Pagination is offset based, so we remove these logs client-side.
if (
node.__typename === 'AssetMaterializationPlannedEvent' ||
node.__typename === 'AssetCheckEvaluationPlannedEvent'
node.__typename === 'AssetCheckEvaluationPlannedEvent' ||
node.__typename === 'PlannedAssetMaterializationFailureEvent' ||
node.__typename === 'PlannedAssetMaterializationSkippedEvent'
) {
return false;
}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading