[ui] Allow deleting dynamic partitions from asset pages #23462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit af53f8a. |
bengotow
commented
Aug 7, 2024
js_modules/dagster-ui/packages/ui-core/src/assets/AssetTableFragment.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/useReportEventsModal.tsx
Show resolved
Hide resolved
js_modules/dagster-ui/packages/ui-core/src/assets/useReportEventsModal.tsx
Show resolved
Hide resolved
bengotow
force-pushed
the
bengotow-2024-08/FE-491
branch
2 times, most recently
from
4e76e18 to
e1dab2e
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bengotow
force-pushed
the
bengotow-2024-08/FE-491
branch
from
e04d243 to
c31d15e
Compare
salazarm
approved these changes
Aug 15, 2024
bengotow
force-pushed
the
bengotow-2024-08/FE-491
branch
from
c31d15e to
44e8f1a
Compare
bengotow
force-pushed
the
bengotow-2024-08/FE-491
branch
from
44e8f1a to
af53f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes #14026
This PR adds a new "delete partitions" modal in both OSS and Plus that allows you to remove dynamic partitions from the UI. The UI immediately updates to reflect the change.
During testing I also found that our current UI for adding dynamic partitions didn't work quite right in cases where the dynamic partition was one of the dimensions of a multi-dimensional partition def, because the
dimension.nameand thedimension.dynamicPartitionsDefinitionNameare not the same, and the Add Partition mutation requires the latter.The new dropdown option in these screenshots only appears if the asset has a dynamic partition dimension, so non-dynamic assets are unimpacted.
How I Tested These Changes
There's a new test file covering this modal!
I also tested this manually using both assets that have dynamic partitions and assets that have multi-dimensional partition defs where one axis is dynamic. Also verified the changes in the report materialization events modal and the wipe assets implementation on the asset table didn't have any impact.