Add --header/-H to dapr invoke #1287

hunter007 · 2023-05-20T14:48:48Z

Description

to support pass customized headers to dapr app

See dapr/go-sdk#405

Issue reference

Fix #1286

Signed-off-by: hunter007 <[email protected]>

…_1286

mukundansundar

@hunter007 Thanks for adding this feature.
Can you add E2E for the this feature please?

Signed-off-by: hunter007 <[email protected]>

hunter007 · 2023-05-23T01:04:44Z

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

mukundansundar · 2023-05-26T12:53:09Z

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

hunter007 · 2023-05-26T20:03:56Z

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

Yes, so the PR could be reviewd.

mukundansundar · 2023-05-30T16:46:26Z

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

Yes, so the PR could be reviewd.

Won't the dependency need to be updated to point to the latest go-sdk in this case?

hunter007 · 2023-05-31T00:38:26Z

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

Yes, so the PR could be reviewd.

Won't the dependency need to be updated to point to the latest go-sdk in this case?

no need.

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

@hunter007 Thanks for adding this feature. Can you add E2E for the this feature please?

:) Review this PR first: dapr/go-sdk#405

seems the PR has been merged :)

Yes, so the PR could be reviewd.

Won't the dependency need to be updated to point to the latest go-sdk in this case?

No need. dapr/go-sdk#405 is used when writing app with go-sdk. Without dapr/go-sdk#405, cli invoke will still send HTTP header by -H to dapr app

mukundansundar · 2023-05-31T05:36:32Z

@hunter007 the specific test that you have written seems to fail output does not contain "aValue" ... Can you take a look into this?

hunter007 · 2023-06-05T11:56:43Z

@hunter007 the specific test that you have written seems to fail output does not contain "aValue" ... Can you take a look into this?

It dependent on dapr/go-sdk which's version is after v1.7.0.

mukundansundar · 2023-06-07T04:24:55Z

@hunter007 the specific test that you have written seems to fail output does not contain "aValue" ... Can you take a look into this?

It dependent on dapr/go-sdk which's version is after v1.7.0.

This PR needs to be modified to use the latest go-sdk then in tests.

mukundansundar · 2023-06-13T05:23:25Z

@hunter007 1.8 version of go-sdk was released and I believe that needs to be used for the header functionality to work.

Signed-off-by: hunter007 <[email protected]>

codecov · 2023-06-17T06:23:42Z

Codecov Report

Merging #1287 (83d8a3a) into master (31b9ea2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
+ Coverage   26.81%   26.87%   +0.05%     
==========================================
  Files          39       39              
  Lines        3882     3885       +3     
==========================================
+ Hits         1041     1044       +3     
  Misses       2767     2767              
  Partials       74       74

Impacted Files	Coverage Δ
pkg/standalone/client.go	`0.00% <ø> (ø)`
pkg/standalone/invoke.go	`73.33% <100.00%> (+1.90%)`	⬆️

hunter007 · 2023-06-22T19:07:04Z

@mukundansundar github action timeouted, have a retry?

mukundansundar

small changes please.

mukundansundar · 2023-06-23T06:49:02Z

cmd/invoke.go

@@ -98,6 +121,7 @@ func init() {
 	InvokeCmd.Flags().StringVarP(&invokeData, "data", "d", "", "The JSON serialized data string (optional)")
 	InvokeCmd.Flags().StringVarP(&invokeVerb, "verb", "v", defaultHTTPVerb, "The HTTP verb to use")
 	InvokeCmd.Flags().StringVarP(&invokeDataFile, "data-file", "f", "", "A file containing the JSON serialized data (optional)")
+	InvokeCmd.Flags().StringArrayVarP(&invokeHeaders, "header", "H", []string{}, "0 or more HTTP Header")


Suggested change

InvokeCmd.Flags().StringArrayVarP(&invokeHeaders, "header", "H", []string{}, "0 or more HTTP Header")

InvokeCmd.Flags().StringArrayVarP(&invokeHeaders, "header", "H", []string{}, "HTTP headers to be used on invoke")

cmd/invoke.go

mukundansundar · 2023-06-23T06:50:41Z

pkg/standalone/invoke_test.go

 			resp:         "successful invoke",
 		},
+		{
+			name:   "appID found successful invoke with customized header",


please add one test with multiple header values.

Signed-off-by: hunter007 <[email protected]>

Add --header/-H to dapr invoke

7a8b16b

Signed-off-by: hunter007 <[email protected]>

hunter007 marked this pull request as ready for review May 20, 2023 14:52

hunter007 requested review from a team as code owners May 20, 2023 14:52

hunter007 mentioned this pull request May 20, 2023

Make dapr app using http protocol support customized headers dapr/go-sdk#404

Closed

shubham1172 and others added 2 commits May 20, 2023 20:40

Merge branch 'master' into issue_1286

90ae537

Fix S1031: unnecessary nil check around range (gosimple)

da89235

Signed-off-by: hunter007 <[email protected]>

hunter007 mentioned this pull request May 20, 2023

Pass HTTP headers to ServiceInvocationHandler dapr/go-sdk#405

Merged

Merge branch 'issue_1286' of github.com:hunter007/dapr-cli into issue…

6c5274f

…_1286

mukundansundar reviewed May 22, 2023

View reviewed changes

Add E2E for dapr invoke

c6be417

Signed-off-by: hunter007 <[email protected]>

hunter007 requested a review from mukundansundar May 24, 2023 22:47

hunter007 added 2 commits May 25, 2023 22:36

Merge branch 'master' into issue_1286

bbaa314

Merge branch 'master' into issue_1286

b5bf40d

Merge branch 'master' into issue_1286

b35d562

Merge branch 'master' into issue_1286

3fc267b

hunter007 added 2 commits June 15, 2023 07:42

Merge branch 'master' into issue_1286

fbd2638

update github.com/dapr/go-sdk from v1.6.0 to v1.8.0

9fab57b

Signed-off-by: hunter007 <[email protected]>

Merge branch 'master' into issue_1286

e458f37

mukundansundar requested changes Jun 23, 2023

View reviewed changes

Fix

ddd24fb

Signed-off-by: hunter007 <[email protected]>

hunter007 requested a review from mukundansundar June 23, 2023 13:47

hunter007 and others added 2 commits June 28, 2023 10:32

Merge branch 'master' into issue_1286

90bc493

Merge branch 'master' into issue_1286

83d8a3a

hunter007 closed this Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --header/-H to dapr invoke #1287

Add --header/-H to dapr invoke #1287

hunter007 commented May 20, 2023 •

edited

Loading

mukundansundar left a comment

hunter007 commented May 23, 2023

mukundansundar commented May 26, 2023

hunter007 commented May 26, 2023

mukundansundar commented May 30, 2023

hunter007 commented May 31, 2023

mukundansundar commented May 31, 2023

hunter007 commented Jun 5, 2023

mukundansundar commented Jun 7, 2023

mukundansundar commented Jun 13, 2023

codecov bot commented Jun 17, 2023 •

edited

Loading

hunter007 commented Jun 22, 2023

mukundansundar left a comment •

edited

Loading

mukundansundar Jun 23, 2023

mukundansundar Jun 23, 2023

	InvokeCmd.Flags().StringArrayVarP(&invokeHeaders, "header", "H", []string{}, "0 or more HTTP Header")
	InvokeCmd.Flags().StringArrayVarP(&invokeHeaders, "header", "H", []string{}, "HTTP headers to be used on invoke")

Add --header/-H to dapr invoke #1287

Add --header/-H to dapr invoke #1287

Conversation

hunter007 commented May 20, 2023 • edited Loading

Description

Issue reference

mukundansundar left a comment

Choose a reason for hiding this comment

hunter007 commented May 23, 2023

mukundansundar commented May 26, 2023

hunter007 commented May 26, 2023

mukundansundar commented May 30, 2023

hunter007 commented May 31, 2023

mukundansundar commented May 31, 2023

hunter007 commented Jun 5, 2023

mukundansundar commented Jun 7, 2023

mukundansundar commented Jun 13, 2023

codecov bot commented Jun 17, 2023 • edited Loading

Codecov Report

hunter007 commented Jun 22, 2023

mukundansundar left a comment • edited Loading

Choose a reason for hiding this comment

mukundansundar Jun 23, 2023

Choose a reason for hiding this comment

mukundansundar Jun 23, 2023

Choose a reason for hiding this comment

hunter007 commented May 20, 2023 •

edited

Loading

codecov bot commented Jun 17, 2023 •

edited

Loading

mukundansundar left a comment •

edited

Loading