Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass HTTP headers to ServiceInvocationHandler #405

Merged
merged 6 commits into from
May 25, 2023
Merged

Conversation

hunter007
Copy link
Contributor

@hunter007 hunter007 commented May 20, 2023

dapr app using grpc protocol supports customized headers via metadata.
But dapr app using http protocol can not.

With the feature finished, dapr invoke supports --header/-H to pass customized header.

Fix #404

See: dapr/cli#1287

@hunter007 hunter007 marked this pull request as ready for review May 20, 2023 15:59
@hunter007 hunter007 requested a review from a team as a code owner May 20, 2023 15:59
@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #405 (f26bf60) into main (b2275e7) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   68.95%   69.08%   +0.13%     
==========================================
  Files          31       31              
  Lines        2480     2491      +11     
==========================================
+ Hits         1710     1721      +11     
  Misses        676      676              
  Partials       94       94              
Impacted Files Coverage Δ
service/http/invoke.go 85.96% <100.00%> (+3.35%) ⬆️

Signed-off-by: hunter007 <[email protected]>
Signed-off-by: hunter007 <[email protected]>
@yaron2 yaron2 merged commit b14253b into dapr:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dapr app using http protocol support customized headers
2 participants