This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Fix lints, tiny bump to pkg:test #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
commented
Sep 8, 2024
| @@ -15,4 +15,4 @@ environment: | |||
|
|
|||
| dev_dependencies: | |||
| dart_flutter_team_lints: ^3.0.0 | |||
| test: ^1.16.0 | |||
| test: ^1.16.6 | |||
There was a problem hiding this comment.
via _PUB_TEST_SDK_VERSION=3.2.0 dart pub downgrade --tighten
kevmoo
commented
Sep 8, 2024
| @@ -348,7 +348,6 @@ class BoundMultipartStream { | |||
| default: | |||
| // Should be unreachable. | |||
| assert(false); | |||
| break; | |||
There was a problem hiding this comment.
This linted locally, but not on CI.
kevmoo
commented
Sep 8, 2024
| @@ -8,7 +8,7 @@ import 'dart:convert'; | |||
| import 'char_code.dart' as char_code; | |||
| import 'mime_shared.dart'; | |||
|
|
|||
| /// Bytes for '()<>@,;:\\"/[]?={} \t'. | |||
| /// Bytes for `()<>@,;:\\"/[]?={} \t`. | |||
There was a problem hiding this comment.
This linted on CI (via the dartdoc HTML lint), but not locally. 🤷
There was a problem hiding this comment.
Perhaps version skew in the sdk versions?
devoncarew
approved these changes
Sep 9, 2024
| @@ -8,7 +8,7 @@ import 'dart:convert'; | |||
| import 'char_code.dart' as char_code; | |||
| import 'mime_shared.dart'; | |||
|
|
|||
| /// Bytes for '()<>@,;:\\"/[]?={} \t'. | |||
| /// Bytes for `()<>@,;:\\"/[]?={} \t`. | |||
There was a problem hiding this comment.
Perhaps version skew in the sdk versions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.