Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Fix lints, tiny bump to pkg:test #133

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Fix lints, tiny bump to pkg:test #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/src/bound_multipart_stream.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import 'dart:convert';
import 'char_code.dart' as char_code;
import 'mime_shared.dart';

/// Bytes for '()<>@,;:\\"/[]?={} \t'.
/// Bytes for `()<>@,;:\\"/[]?={} \t`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This linted on CI (via the dartdoc HTML lint), but not locally. 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps version skew in the sdk versions?

const _separators = {
40, 41, 60, 62, 64, 44, 59, 58, 92, 34, 47, 91, 93, 63, 61, 123, 125, 32, 9 //
};
Expand Down Expand Up @@ -348,7 +348,6 @@ class BoundMultipartStream {
default:
// Should be unreachable.
assert(false);
break;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This linted locally, but not on CI.

}

// Move to the next byte.
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ environment:

dev_dependencies:
dart_flutter_team_lints: ^3.0.0
test: ^1.16.0
test: ^1.16.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via _PUB_TEST_SDK_VERSION=3.2.0 dart pub downgrade --tighten