Fix(pydataverse tests): Adapt to behavior change in upload file #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Backstory is in #320 (comment). A change outside of datalad-dataverse resulted in a 400 bad request whenever pydataverse's upload_file() function was called without passing anything as json_str, and its default value None was used. In the pydataverse tests we perform a simplistic upload, where this parameter . hasn't yet benn used. This change adds empty json to make the API call succeed.
|
(this change depends on gdcc/pyDataverse#203, and should still leave three tests failing) |
This was referenced Jul 24, 2024
|
obsolete with gdcc/pyDataverse#207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Backstory is in #320 (comment). A change outside of datalad-dataverse resulted in a 400 bad request whenever pydataverse's
upload_file()function was called without passing anything asjson_str, and its default value None was used.In the pydataverse tests we perform a simplistic upload, where this parameter hasn't yet been used. This change adds empty json to make the API call succeed.